fix: propagate error on target.Close() in copyFile#581
Open
vedant21-oss wants to merge 1 commit intourunc-dev:mainfrom
Open
fix: propagate error on target.Close() in copyFile#581vedant21-oss wants to merge 1 commit intourunc-dev:mainfrom
vedant21-oss wants to merge 1 commit intourunc-dev:mainfrom
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Hello @vedant21-oss , thank you for the PR, please read the contribution guide. |
Properly propagates the error when closing the target file during copyFile to avoid corrupted rootfs if the file fails to close/flush. Fixes: urunc-dev#566 Signed-off-by: vedant21-oss <vedantmalodeofficial@gmail.com>
vedant21-oss
force-pushed
the
fix-copyfile-close
branch
from
1e3e5df to
7e2b204
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #566
Properly propagates the error when closing the target file during copyFile to avoid corrupted rootfs if the file fails to close/flush.