Clippy Pedantic Acceptable Commits#6738
Closed
dcampbell24 wants to merge 10 commits intouutils:mainfrom
Closed
Conversation
Contributor
Author
BenWiederhake
approved these changes
Sep 28, 2024
Collaborator
There was a problem hiding this comment.
LGTM, the changes are easily readable and clearly correspond to each clippy lint. This could be merged as-is.
Bonus points if you also change the two small things that samueltardieu and I mentioned (preallocating the string and fixing a misleading variable name).
Change `bytes` to `hex`. Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
Contributor
|
could you please merge the two last commits into the relevant commit? git rebase -i origin/main |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the commits which you said you would accept.
#6720