Clippy Pedantic Acceptable Commits Try Again#6748
Merged
sylvestre merged 9 commits intouutils:mainfrom Sep 30, 2024
Merged
Conversation
|
GNU testsuite comparison: |
Collaborator
|
You can force push to branches to overture old commits so you don't have to create new PRs. I'll try to look at this tomorrow |
tertsdiepraam
approved these changes
Sep 29, 2024
Collaborator
tertsdiepraam
left a comment
tertsdiepraam
left a comment
There was a problem hiding this comment.
Great! Yeah this all looks good!
Collaborator
|
@sylvestre @cakebaker How are these GNU tests doing? Are they usual suspects for intermittently failing tests? |
Contributor
|
@tertsdiepraam: yes, they are the usual suspects for intermittently failing tests :| @dcampbell24: thanks! |
Collaborator
|
Yes, please use force-push in the future to preserve discussions about a PR :) |
Contributor
Author
|
Sure, I didn't know that I could do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the wording of a commit to include
clippy::.#6738
#6746