Skip to content

refactor: reduce cognitive complexity of create and list operations#303

Merged
sylvestre merged 1 commit into
uutils:mainfrom
kaladron:reduce-complexity
Jun 15, 2026
Merged

refactor: reduce cognitive complexity of create and list operations#303
sylvestre merged 1 commit into
uutils:mainfrom
kaladron:reduce-complexity

Conversation

@kaladron

Copy link
Copy Markdown
Collaborator

No description provided.

@codspeed-hq

codspeed-hq Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 7 untouched benchmarks


Comparing kaladron:reduce-complexity (791ae26) with main (a997eda)

Open in CodSpeed

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.84%. Comparing base (cef2373) to head (791ae26).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/uu/tar/src/operations/list.rs 88.63% 5 Missing ⚠️
src/uu/tar/src/operations/create.rs 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   96.78%   96.84%   +0.06%     
==========================================
  Files           9       11       +2     
  Lines        1121     1492     +371     
  Branches       28       29       +1     
==========================================
+ Hits         1085     1445     +360     
- Misses         35       46      +11     
  Partials        1        1              
Flag Coverage Δ
macos_latest 96.84% <90.90%> (+0.06%) ⬆️
ubuntu_latest 96.84% <90.90%> (+0.06%) ⬆️
windows_latest 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kaladron kaladron requested a review from sylvestre June 15, 2026 07:21
@kaladron

Copy link
Copy Markdown
Collaborator Author

I'm factoring out some code to make it easier to follow. I've also sent #304 to make the coverage warning non-blocking since it's falsely failing here.

@sylvestre sylvestre merged commit 9dd7012 into uutils:main Jun 15, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants