Skip to content

Make codecov non-blocking#304

Merged
kaladron merged 1 commit into
uutils:mainfrom
kaladron:fix-codecov-config
Jun 15, 2026
Merged

Make codecov non-blocking#304
kaladron merged 1 commit into
uutils:mainfrom
kaladron:fix-codecov-config

Conversation

@kaladron

Copy link
Copy Markdown
Collaborator

Similar to uutils/coreutils, make codecov non-blocking for new patches. We will enforce this socially instead of mechanically.

Unlike uutils/coreutils, we still want the comment in the comment thread.

@kaladron kaladron requested a review from sylvestre June 15, 2026 06:33
@codspeed-hq

codspeed-hq Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 7 untouched benchmarks


Comparing kaladron:fix-codecov-config (acbc358) with main (a997eda)

Open in CodSpeed

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.89%. Comparing base (cef2373) to head (acbc358).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   96.78%   96.89%   +0.10%     
==========================================
  Files           9       11       +2     
  Lines        1121     1481     +360     
  Branches       28       29       +1     
==========================================
+ Hits         1085     1435     +350     
- Misses         35       45      +10     
  Partials        1        1              
Flag Coverage Δ
macos_latest 96.89% <ø> (+0.10%) ⬆️
ubuntu_latest 96.89% <ø> (+0.10%) ⬆️
windows_latest 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevinburke

Copy link
Copy Markdown
Contributor

You could also try lowering the required coverage... it's currently at 96.8% requirement

@kaladron

Copy link
Copy Markdown
Collaborator Author

You could also try lowering the required coverage... it's currently at 96.8% requirement

I think it's set to never allow it to go down, which might be a touch unrealistic. I'd love to tweak this further but want to get this landed in the meantime.

Thank you!

@kaladron kaladron merged commit 4c1c362 into uutils:main Jun 15, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants