Stay consistent with the Create/Refresh buttons order#7102
Merged
cbosdo merged 5 commits intouyuni-project:masterfrom Jun 7, 2023
Merged
Stay consistent with the Create/Refresh buttons order#7102cbosdo merged 5 commits intouyuni-project:masterfrom
cbosdo merged 5 commits intouyuni-project:masterfrom
Conversation
HoussemNasri
changed the title
HoussemNasri
changed the title
cbosdo
approved these changes
Jun 7, 2023
Contributor
cbosdo
left a comment
cbosdo
left a comment
There was a problem hiding this comment.
LGTM, I would just rephrase the changelog entry to make it a bit shorter
… create-refresh-consistency # Conflicts: # web/spacewalk-web.changes
cbbayburt
approved these changes
Jun 7, 2023
Contributor
cbbayburt
left a comment
cbbayburt
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for the contribution!
To the person who's gonna do the merge: please squash the commits with a descriptive message when merging.
Contributor
I usually prefer to not rely on this Github feature, but squash them locally with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
On the Images List page, the buttons are ordered: Import, Refresh, while on other pages like the Profiles one, the order is Refresh, Create. This PR modifies the Profiles and Stores pages button ordering to stay consistent with the Image List page.
GUI diff
Before:
The refresh button used to precede the create button on the profiles and stores pages
After:
Documentation
No documentation needed: add explanation. This can't be used if there is a GUI diff
No documentation needed: only internal and user invisible changes
Documentation issue was created: Link for SUSE Manager contributors, Link for community contributors.
API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.
(OPTIONAL) Documentation PR
DONE
Test coverage
No tests: already covered
DONE
Links
Fixes #360
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: