Skip to content

Stay consistent with the Create/Refresh buttons order #7102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbosdo merged 5 commits into from
Jun 7, 2023
Merged

Stay consistent with the Create/Refresh buttons order #7102

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2aa2fee
Fix
HoussemNasri Jun 6, 2023
8d6c5a1
Add changelog entry
HoussemNasri Jun 6, 2023
f26db60
Merge branch 'master' into create-refresh-consistency
HoussemNasri Jun 6, 2023
3c6fac4
Update changelog
HoussemNasri Jun 7, 2023
7ac1c3f
Merge remote-tracking branch 'origin/create-refresh-consistency' into…
HoussemNasri Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/html/src/manager/images/image-profiles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ class ImageProfiles extends React.Component<Props, State> {
target="delete-selected-modal"
/>
)}
<AsyncButton id="reload" icon="fa-refresh" text={t("Refresh")} action={this.reloadData} />
{window.isAdmin && (
<LinkButton
id="create"
Expand All @@ -149,6 +148,7 @@ class ImageProfiles extends React.Component<Props, State> {
href="/rhn/manager/cm/imageprofiles/create"
/>
)}
<AsyncButton id="reload" icon="fa-refresh" text={t("Refresh")} action={this.reloadData} />
</div>
);

Expand Down
2 changes: 1 addition & 1 deletion web/html/src/manager/images/image-stores.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ class ImageStores extends React.Component<Props, State> {
target="delete-selected-modal"
/>
)}
<AsyncButton id="reload" icon="fa-refresh" text={t("Refresh")} action={this.reloadData} />
{window.isAdmin && (
<LinkButton
id="create"
Expand All @@ -149,6 +148,7 @@ class ImageStores extends React.Component<Props, State> {
href="/rhn/manager/cm/imagestores/create"
/>
)}
<AsyncButton id="reload" icon="fa-refresh" text={t("Refresh")} action={this.reloadData} />
</div>
);

Expand Down
3 changes: 3 additions & 0 deletions web/spacewalk-web.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
- Change the order of the Refresh and Create buttons on the
image-profiles and image-stores pages to stay consistent
with the image-list page.
- Fix layout alignment on pages showing failed states logs (bsc#1211713)
- Fix parsing error when showing notification message details (bsc#1211469)
- Fix spelling on monitoring-admin page.
Expand Down