feat: initial tls support for valkey cluster#133
Merged
sandeepkunusoth merged 3 commits intoApr 20, 2026
Conversation
Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
jdheyburn
reviewed
Apr 14, 2026
daanvinken
reviewed
Apr 15, 2026
Contributor
daanvinken
left a comment
daanvinken
left a comment
There was a problem hiding this comment.
Should we have a watcher or use an annotation to make sure cert renewals roll the cluster?
Member
Author
we have added watcher for secrets managed by cert-manager and hash annotation to check changes in certs in our internal operator and performed config set on tls cert renewals. this can be added in next iterations as this will be seperate enhancement. we can also use tls-auto-reload-interval 86400 to automatically reload certs https://valkey.io/topics/tls/#:~:text=tls%2Dauto%2Dreload%2Dinterval%2086400 |
daanvinken
approved these changes
Apr 16, 2026
Signed-off-by: sandeep kunusoth <31273507+sandeepkunusoth@users.noreply.github.com>
bjosv
reviewed
Apr 17, 2026
Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
sandeepkunusoth
changed the title
Collaborator
|
One thing missing from this PR is documentation, cc @sandeepkunusoth |
jdheyburn
pushed a commit
that referenced
this pull request
Apr 22, 2026
…145) ## Description The merge of #128 (proactive failovers) after #133 (TLS) introduced a build-breaking call. #133 added a `cluster` parameter to `getValkeyClusterState`, but #128's new call site at line 445 used the old signature without it. This causes a compile error on current main. ## Testing `go build ./...` passes. Signed-off-by: Daan Vinken <daanvinken@tythus.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Adds initial TLS/SSL Support for Valkey Cluster #59.
Summary
This PR introduces initial TLS support for Valkey clusters(SERVER SIDE).
Changes
tls-port,port 0,tls-cert-file,tls-key-file,tls-ca-cert-fileImplementation
Testing
Next steps
Checklist
Before submitting the PR make sure the following are checked:
pre-commit run --all-filesor hooks on commit)