fix: pass cluster arg to getValkeyClusterState in proactive failover#145
Merged
jdheyburn merged 1 commit intoApr 22, 2026
Merged
Conversation
The merge of valkey-io#128 (proactive failovers) after valkey-io#133 (TLS) introduced a build-breaking call. valkey-io#133 added a cluster parameter to getValkeyClusterState, but valkey-io#128's new call site used the old signature. Signed-off-by: Daan Vinken <daanvinken@tythus.com>
Contributor
Author
jdheyburn
approved these changes
Apr 22, 2026
Collaborator
|
@daanvinken This is worth bringing up at the weekly call - I won't be able to make this weeks one though. I'll put a message out on Slack on the day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The merge of #128 (proactive failovers) after #133 (TLS) introduced a build-breaking call. #133 added a
clusterparameter togetValkeyClusterState, but #128's new call site at line 445 used the old signature without it. This causes a compile error on current main.Testing
go build ./...passes.