example: new example demonstrating an ASK modulator by WasteOfO2 · Pull Request #28 · vicharak-in/shrike

WasteOfO2 · 2025-12-16T12:29:36Z

Added a new example demonstrating an Amplitude Shift Key modulator using both - the FPGA and the microcontroller.

Part of the README was made using assistance of LLMs, but has been confirmed to be valid and correct.

I am not sure if a video is necessary demonstrating the same, if needed will add it for reference

The example consists of the project file, source for the verilog code alongside the testbench for verification, python script for input or whatever code is to be actually transmitted and lastly, the bitstream to note the output for the same

Please do let me know if any additional changes are needed, thank you!

maow

dpks2003 · 2025-12-16T12:34:43Z

Hello @WasteOfO2 Thank you for Contribution.
We will review your PR now.

dpks2003

Please check the comments and do the required changes.

dpks2003 · 2025-12-16T12:35:49Z

docs/shrike_cli_guide.md

@@ -1,5 +1,3 @@
-(shrike_cli_guide)=


this change is disruptive as it needed fro sphinex to render it properly. Revert this

dpks2003 · 2025-12-16T12:36:25Z

docs/shrike_cli_guide.md

 Onces the fpga is flashed you should see the led connected to fpga blinking.

 The mpremote has a lot more features as well you can check them all out in there guide [here](https://docs.micropython.org/en/latest/reference/mpremote.html#).



Will suggest completely reverting any changes in this file.

Please revert this file these changes does not need's to be committed.
Just reset this file to current main.

i just directly copy pasted from what it currently is upstream as i figured that would be easier, in case that isnt sufficient i will just revert it as usual

please revert it as copy pasting will still get into git log which , will rebuild the docs without any real changes. I hope you understand.

dpks2003 · 2025-12-16T12:37:36Z

examples/ask_modulator/ffpga/sim/main_tb.vt

@@ -0,0 +1,67 @@
+`timescale 1ns / 1ps
+


what is the difference between main_tb.vt and main_tb.v

ah, i forgot to remove the older file as it didnt work as expected, will remove all the unnecessary files in the coming commit

dpks2003 · 2025-12-16T12:38:15Z

examples/ask_modulator/ffpga/src/bruh.v

A proper file name would be needed here bruh.v is cool however unacceptable for a pr

my bad, this file was not supposed to exist here

dpks2003 · 2025-12-16T12:39:20Z

examples/ask_modulator/ffpga/src/main_tb.v

Why is there a main_tb.v in the src file.

no idea, will be removed right away

dpks2003 · 2025-12-16T12:40:14Z

examples/ask_modulator/firmware/micropython/ask_modulator.py

again proper naming and this should into a firmware subfolder in your project folder checkout ultrasonic example for reference

a proper name for this file and name the dir as micropython instead of python_script

directory can be renamed, however i would want to know what other name can be used instead of helloshrike.py as i named it after the sequence that should be shown on the DSO/CRO

maybe ask_modulator.py would be a better name and in the comments in teh file you can mention it send's hello word.

dpks2003 · 2025-12-16T12:40:55Z

examples/ask_modulator/ask_modulator.ffpga

again the user should be sure what example they are running so proper naming here

will be renamed right away

dpks2003 · 2025-12-16T12:42:24Z

examples/ask_modulator/FPGA_bitstream_MCU.bin

.bin file or bit-stream are not required in the repo they should be generated by user.

will remove this, kept it as a working reference for users willing to just flash and get the desired output

dpks2003 · 2025-12-16T12:44:48Z

@WasteOfO2 your implementation is fine however the PR requires clean up , have added comments for that please do the needful.

Remove obsolete simulation sources and binary bitstream, rename the ffpga file, and move helloshrike.py into the firmware/python_script path.

WasteOfO2 · 2025-12-16T14:39:39Z

@dpks2003 kindly review the changes, let me know if further changes are needed

dpks2003 · 2025-12-17T04:02:33Z

examples/ask_modulator/firmware/micropython/ask_modulator.py

a proper name for this file and name the dir as micropython instead of python_script

dpks2003 · 2025-12-17T04:04:29Z

docs/shrike_cli_guide.md

 Onces the fpga is flashed you should see the led connected to fpga blinking.

 The mpremote has a lot more features as well you can check them all out in there guide [here](https://docs.micropython.org/en/latest/reference/mpremote.html#).



Please revert this file these changes does not need's to be committed.
Just reset this file to current main.

WasteOfO2 · 2025-12-17T13:05:19Z

@dpks2003 changed the directory name as requested, do suggest a naming convention for firmware be it for micropython, arduino, etc files so it can be ironed out down the line

dpks2003 · 2025-12-18T06:26:13Z

docs/shrike_cli_guide.md

 Onces the fpga is flashed you should see the led connected to fpga blinking.

 The mpremote has a lot more features as well you can check them all out in there guide [here](https://docs.micropython.org/en/latest/reference/mpremote.html#).



please revert it as copy pasting will still get into git log which , will rebuild the docs without any real changes. I hope you understand.

dpks2003 · 2025-12-18T06:27:19Z

examples/ask_modulator/firmware/micropython/ask_modulator.py

maybe ask_modulator.py would be a better name and in the comments in teh file you can mention it send's hello word.

dpks2003 · 2025-12-18T06:28:41Z

@dpks2003 changed the directory name as requested, do suggest a naming convention for firmware be it for micropython, arduino, etc files so it can be ironed out down the line

sure @WasteOfO2 i am working on a contribution guide which will have all the conventions and guideline.

Thank You

dpks2003 · 2025-12-18T06:30:14Z

also suggesting you to squash all of these in a single commit .

…li_guide.md to commit b99b54e

WasteOfO2 · 2025-12-21T19:23:07Z

hello @dpks2003 , sorry i was traveling so couldnt get back to this

multiple commits other than mine were made in this duration, are you fine with me squashing those as well?

WasteOfO2 · 2025-12-21T20:20:42Z

Seem to have squashed them locally but I am not sure if github has reflected that, never really worked with squashing before so i apologize

dpks2003 · 2025-12-23T06:15:45Z

@WasteOfO2 it did not work no worries i will do it will merging.
Thank You for the contribution . Your PR will be merged soon

WasteOfO2 added 3 commits December 5, 2025 13:47

fix: use mpremote fs instead of mpremote <fs command> directly

8bb2457

example: added a new example demonstrating an ASK modulator

0db39cf

Merge branch 'main' of https://github.com/WasteOfO2/shrike-lite

b638bc6

maow

dpks2003 requested changes Dec 16, 2025

View reviewed changes

dpks2003 added fpga Issue in the FPGA side of the Shrike RP2040 issue in the RP2040 side of shrike. examples labels Dec 16, 2025

Clean up ask_modulator example and revert CLI guide

f64b3f8

Remove obsolete simulation sources and binary bitstream, rename the ffpga file, and move helloshrike.py into the firmware/python_script path.

WasteOfO2 force-pushed the main branch from 5967464 to f64b3f8 Compare December 16, 2025 14:35

dpks2003 requested changes Dec 17, 2025

View reviewed changes

fix: rename the python_script directory to micropython

0bdf2f7

dpks2003 requested changes Dec 18, 2025

View reviewed changes

WasteOfO2 added 2 commits December 22, 2025 00:23

fix: renamed helloshrike.py to ask_modulator.py and reverted shrike_c…

4749483

…li_guide.md to commit b99b54e

fix: renamed helloshrike.py to ask_modulator.py and reverted shrike_c…

dcae595

…li_guide.md to commit b99b54e

Merge branch 'vicharak-in:main' into main

7273f75

dpks2003 merged commit d2d4d3f into vicharak-in:main Dec 23, 2025

		Onces the fpga is flashed you should see the led connected to fpga blinking.

		The mpremote has a lot more features as well you can check them all out in there guide [here](https://docs.micropython.org/en/latest/reference/mpremote.html#).

Conversation

WasteOfO2 commented Dec 16, 2025

Uh oh!

dpks2003 commented Dec 16, 2025

Uh oh!

dpks2003 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dpks2003 commented Dec 16, 2025

Uh oh!

WasteOfO2 commented Dec 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WasteOfO2 commented Dec 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dpks2003 commented Dec 18, 2025

Uh oh!

dpks2003 commented Dec 18, 2025

Uh oh!

WasteOfO2 commented Dec 21, 2025

Uh oh!

WasteOfO2 commented Dec 21, 2025

Uh oh!

dpks2003 commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development