Add CRS for creating management package repository and for installing featuregates, core-management-plugins package by yharish991 · Pull Request #1046 · vmware-tanzu/tanzu-framework

yharish991 · 2021-11-03T02:34:42Z

What this PR does / why we need it

This PR adds ClusterResourceSet custom resource to

Create management package repository
Install featuregates package
Install core-management-plugins package

Which issue(s) this PR fixes

Describe testing done for PR

Release note

Added ClusterResourceSet resources to create management package repository and to install featuregates package

PR Checklist

Squash the commits into one or a small number of logical commits
Use good commit messages
Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

This PR needs to be tested after the management package repo entry is added to BOM. But wanted to get an initial review on the approach

pkg/v1/providers/ytt/02_addons/management-packages/add_management_package_repo.yaml

github-actions · 2021-11-03T02:47:36Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211103024734/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

rajathagasthya · 2021-11-04T08:01:39Z

Just curious how this works on an upgrade. We want the latest packages from this repo to be installed when management cluster is upgraded (means the existing packages get upgraded). Is doing this via CRS able to ensure that?

yharish991 · 2021-11-04T12:40:24Z

@rajathagasthya

Just curious how this works on an upgrade. We want the latest packages from this repo to be installed when management cluster is upgraded (means the existing packages get upgraded). Is doing this via CRS able to ensure that?

If the cluster is being upgraded, the PackageRepository and PackageInstall would be updated directly https://github.com/vmware-tanzu/tanzu-framework/pull/1046/files#diff-049262173b38704098ff511248bfd32198a383381dac188f4d201577d4744c17R166-R167 and https://github.com/vmware-tanzu/tanzu-framework/pull/1046/files#diff-fc81a8233b6918a916988000770b95adc92a1273d339d26cf653b9e422885207R20-R21

PacakgeRepository with upgraded repo bundle will make the latest packages available on the cluster and PackageInstall will pick the latest package and install it

github-actions · 2021-11-04T14:49:10Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211104144907/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-04T14:54:44Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211104145442/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

vijaykatam

I would go through rbac rules for service account and remove the ones that are not needed.

pkg/v1/providers/ytt/02_addons/management-packages/add_featuregates_package.yaml

pkg/v1/tkg/client/upgrade_cluster.go

vijaykatam · 2021-11-04T15:03:42Z

pkg/v1/providers/ytt/02_addons/management-packages/add_featuregates_package.yaml

+      - list
+      - watch
+  - apiGroups:
+      - cert-manager.io


Is cert-manager being used in feature gate package?

yes, we need certificates for the featuregates webhook

github-actions · 2021-11-04T15:41:09Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211104154107/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

pkg/v1/tkg/client/upgrade_cluster.go

pkg/v1/providers/ytt/02_addons/management-packages/add_management_package_repo.yaml

github-actions · 2021-11-05T16:00:37Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211105160034/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-05T19:41:57Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211105194154/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-08T03:14:20Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211108031418/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-09T18:02:37Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211109180235/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-09T19:45:07Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211109194504/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

pkg/v1/tkg/client/upgrade_cluster.go

github-actions · 2021-11-09T19:50:04Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211109195002/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-09T19:55:43Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211109195541/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-09T20:04:51Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211109200448/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-09T20:07:57Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211109200755/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-10T01:41:41Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211110014138/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

yharish991 · 2021-11-10T03:30:47Z

//usebom:sandbox/v1.5.0-zshippable/380806556008107856/tkg-compatibility

github-actions · 2021-11-10T19:29:59Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211110192958/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-10T19:37:47Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211110193745/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Signed-off-by: Harish Yayi <yharish991@gmail.com>

- This change adds core-management-plugins package - It should get applied as part of management cluster creation and management cluster creation process - Sync plugins after management-cluster creation and upgrade

Signed-off-by: Harish Yayi <yharish991@gmail.com>

github-actions · 2021-11-11T18:08:37Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1046/20211111180835/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

yharish991 added kind/feature Categorizes issue or PR as related to a new feature area/lcm Related to Cluster Lifecycle management labels Nov 3, 2021

yharish991 requested review from jmoroski, rajathagasthya and vijaykatam November 3, 2021 02:34

yharish991 assigned jmoroski and vuil Nov 3, 2021

yharish991 requested a review from a team as a code owner November 3, 2021 02:34

vmwclabot added the cla-not-required label Nov 3, 2021

yharish991 commented Nov 3, 2021

View reviewed changes

pkg/v1/providers/ytt/02_addons/management-packages/add_management_package_repo.yaml Outdated Show resolved Hide resolved

yharish991 force-pushed the installMgmtPackages branch 2 times, most recently from ca0f972 to 1f58e93 Compare November 4, 2021 14:43

vijaykatam reviewed Nov 4, 2021

View reviewed changes

yharish991 force-pushed the installMgmtPackages branch from 1f58e93 to 8380992 Compare November 4, 2021 15:27

yharish991 requested a review from blc1996 November 4, 2021 18:12

blc1996 reviewed Nov 4, 2021

View reviewed changes

pkg/v1/tkg/client/upgrade_cluster.go Show resolved Hide resolved

pkg/v1/providers/ytt/02_addons/management-packages/add_management_package_repo.yaml Show resolved Hide resolved

yharish991 force-pushed the installMgmtPackages branch from 8380992 to b624263 Compare November 5, 2021 15:45

yharish991 force-pushed the installMgmtPackages branch from b624263 to 7a87667 Compare November 5, 2021 19:26

yharish991 force-pushed the installMgmtPackages branch 2 times, most recently from 3318e2e to c6bbbef Compare November 8, 2021 03:09

yharish991 force-pushed the installMgmtPackages branch from c6bbbef to 1c0bceb Compare November 8, 2021 03:15

yharish991 force-pushed the installMgmtPackages branch 3 times, most recently from 5c3f1bf to eae8b2b Compare November 9, 2021 19:39

anujc25 reviewed Nov 9, 2021

View reviewed changes

pkg/v1/tkg/client/upgrade_cluster.go Outdated Show resolved Hide resolved

yharish991 force-pushed the installMgmtPackages branch from eae8b2b to 4efe18b Compare November 9, 2021 19:48

yharish991 force-pushed the installMgmtPackages branch from 4efe18b to bcbbaa0 Compare November 9, 2021 19:55

anujc25 mentioned this pull request Nov 9, 2021

Add ClusterResourceSet to install core-management-plugins package #1112

Closed

3 tasks

anujc25 changed the title ~~Add CRS for creating management package repository and for installing featuregates package~~ Add CRS for creating management package repository and for installing featuregates, core-management-plugins package Nov 10, 2021

yharish991 force-pushed the installMgmtPackages branch from 12b7081 to e285706 Compare November 10, 2021 19:23

yharish991 and others added 5 commits November 11, 2021 12:48

add CRS for management package repository

004d2d0

Signed-off-by: Harish Yayi <yharish991@gmail.com>

add CRS for featuregates package

66c2670

Signed-off-by: Harish Yayi <yharish991@gmail.com>

add default FeatureGate resource

2415e3a

Signed-off-by: Harish Yayi <yharish991@gmail.com>

Add core-management-plugins Package

c7c8c55

- This change adds core-management-plugins package - It should get applied as part of management cluster creation and management cluster creation process - Sync plugins after management-cluster creation and upgrade

make digest field in CLIPlugin API optional

c09ada8

Signed-off-by: Harish Yayi <yharish991@gmail.com>

yharish991 force-pushed the installMgmtPackages branch from e285706 to c09ada8 Compare November 11, 2021 17:51

yharish991 merged commit 5e6211b into vmware-tanzu:main Nov 12, 2021

danniel1205 mentioned this pull request Nov 15, 2021

Add ClusterResourceSet to install core-management-plugins package #1110

Closed

10 tasks

This was referenced Nov 15, 2021

Add ClusterResourceSet to install featuregates package #1048

Closed

add ClusterResourceSet for installing Features and FeatureGates in management cluster #642

Closed

Conversation

yharish991 commented Nov 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it

Which issue(s) this PR fixes

Describe testing done for PR

Release note

PR Checklist

Additional information

Special notes for your reviewer

Uh oh!

Uh oh!

github-actions bot commented Nov 3, 2021

Uh oh!

rajathagasthya commented Nov 4, 2021

Uh oh!

yharish991 commented Nov 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 4, 2021

Uh oh!

github-actions bot commented Nov 4, 2021

Uh oh!

vijaykatam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vijaykatam Nov 4, 2021

Choose a reason for hiding this comment

Uh oh!

yharish991 Nov 4, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 4, 2021

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 5, 2021

Uh oh!

github-actions bot commented Nov 5, 2021

Uh oh!

github-actions bot commented Nov 8, 2021

Uh oh!

github-actions bot commented Nov 9, 2021

Uh oh!

github-actions bot commented Nov 9, 2021

Uh oh!

Uh oh!

github-actions bot commented Nov 9, 2021

Uh oh!

github-actions bot commented Nov 9, 2021

Uh oh!

github-actions bot commented Nov 9, 2021

Uh oh!

github-actions bot commented Nov 9, 2021

Uh oh!

github-actions bot commented Nov 10, 2021

Uh oh!

yharish991 commented Nov 10, 2021

Uh oh!

github-actions bot commented Nov 10, 2021

Uh oh!

github-actions bot commented Nov 10, 2021

Uh oh!

github-actions bot commented Nov 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

yharish991 commented Nov 3, 2021 •

edited

Loading

yharish991 commented Nov 4, 2021 •

edited

Loading