Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

add ClusterResourceSet for installing Features and FeatureGates in management cluster#642

Closed
yharish991 wants to merge 1 commit intovmware-tanzu:mainfrom
yharish991:addCRSForFeaturegates
Closed

add ClusterResourceSet for installing Features and FeatureGates in management cluster#642
yharish991 wants to merge 1 commit intovmware-tanzu:mainfrom
yharish991:addCRSForFeaturegates

Conversation

@yharish991
Copy link
Copy Markdown
Contributor

@yharish991 yharish991 commented Sep 16, 2021

Signed-off-by: yharish991 yharish991@gmail.com

What this PR does / why we need it:
This PR adds ClusterResourceSet CR for Feature and FeatureGates in providers template to install them in management cluster.

Which issue(s) this PR fixes:

Fixes #89

Describe testing done for PR:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added ClusterResourceSet CR to install Features and FeatureGates in management cluster

New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate kind label according to what type of issue is being addressed.

Signed-off-by: yharish991 <yharish991@gmail.com>
@yharish991 yharish991 requested review from a team and anujc25 as code owners September 16, 2021 18:36
@yharish991 yharish991 added the kind/feature Categorizes issue or PR as related to a new feature label Sep 16, 2021
@github-actions
Copy link
Copy Markdown

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/642/20210916184808/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@yharish991 yharish991 changed the title add ClusterResourceSet for installing Features and FeatureGates add ClusterResourceSet for installing Features and FeatureGates in management cluster Sep 17, 2021
@yharish991
Copy link
Copy Markdown
Contributor Author

//usebom:sandbox/v1.5.0-zshippable/372947407081581714/tkg-compatibility

@vuil vuil added the ok-to-merge PRs should be labelled with this before merging label Sep 17, 2021
@rajathagasthya
Copy link
Copy Markdown

@yharish991 Should we also add a "system" feature gate resource on the management cluster in this PR?

@yharish991
Copy link
Copy Markdown
Contributor Author

@yharish991 Should we also add a "system" feature gate resource on the management cluster in this PR?

ya I covered that part in this pr #151, it applies a default FeatureGate CR at the time of management cluster creation

@vuil vuil added the area/api label Oct 6, 2021
@yharish991
Copy link
Copy Markdown
Contributor Author

this is not needed anymore as we took a different approach to install Features and FeatureGates using Carvel API #1046

@yharish991 yharish991 closed this Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/api kind/feature Categorizes issue or PR as related to a new feature ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature and FeatureGate into TKG BOM.

3 participants