Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Set AWS loadbalancer scheme to internal when not selecting non internet-facing#1109

Merged
miclettej merged 2 commits intovmware-tanzu:mainfrom
randomvariable:aws-internal-lb
Nov 9, 2021
Merged

Set AWS loadbalancer scheme to internal when not selecting non internet-facing#1109
miclettej merged 2 commits intovmware-tanzu:mainfrom
randomvariable:aws-internal-lb

Conversation

@randomvariable
Copy link
Copy Markdown
Contributor

@randomvariable randomvariable commented Nov 9, 2021

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #
This programatically encodes the workaround for the "This is a non-internet facing VPC" option not working in https://docs.vmware.com/en/VMware-Tanzu-Kubernetes-Grid/1.3/vmware-tanzu-kubernetes-grid-13/GUID-mgmt-clusters-airgapped-environments.html#step-5-initialize-tanzu-kubernetes-grid-9

  • Makefile: Allow OpenAPI generation to work on Fedora SELinux
  • Fix setting AWS loadbalancer scheme to internal

Describe testing done for PR

Tested created clusters via UI and config file with and without internet facing.

Release note

When deploying a regional cluster in a non-internet facing VPC, the AWS ELB scheme is now correctly set to internal.

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

I had to include a fixup to the Makefile to generate the OpenAPI client on Fedora with SELinux enabled.

@randomvariable randomvariable requested a review from a team as a code owner November 9, 2021 17:08
@randomvariable
Copy link
Copy Markdown
Contributor Author

@miclettej can you take a look as I'm fiddling in the frontend without a real clue what I'm doing again.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1109/20211109172333/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1109/20211109181028/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1109/20211109192317/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Copy Markdown
Contributor

@miclettej miclettej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI change looks good. Thank you for taking care of this.

Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@randomvariable
Copy link
Copy Markdown
Contributor Author

Tested locally, ready for merge.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1109/20211109203602/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@miclettej miclettej added the ok-to-merge PRs should be labelled with this before merging label Nov 9, 2021
@miclettej miclettej merged commit 543a835 into vmware-tanzu:main Nov 9, 2021
@randomvariable randomvariable deleted the aws-internal-lb branch November 9, 2021 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-not-required ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants