Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Fix issue with applying ceip yaml to the management cluster#1257

Merged
vuil merged 1 commit intomainfrom
fix_telemetry
Nov 30, 2021
Merged

Fix issue with applying ceip yaml to the management cluster#1257
vuil merged 1 commit intomainfrom
fix_telemetry

Conversation

@saimanoj01
Copy link
Copy Markdown
Contributor

@saimanoj01 saimanoj01 commented Nov 30, 2021

What this PR does / why we need it

Telemetry integration is broken due to a recent update to the telemetry gobindata file in #1109

This change will fix the broken telemetry integration.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Created an Azure management cluster by enabling ceip and made sure telemetry is enabled.

Release note

Fix issue with enabling ceip for tkg management clusters

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@saimanoj01 saimanoj01 requested a review from a team as a code owner November 30, 2021 01:41
@github-actions
Copy link
Copy Markdown

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1257/20211130015505/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@navidshaikh
Copy link
Copy Markdown
Contributor

Please use the PR branches from forked repos. :-)

@vuil vuil self-assigned this Nov 30, 2021
@vuil vuil added ok-to-merge PRs should be labelled with this before merging kind/bug PR/Issue related to a bug labels Nov 30, 2021
Copy link
Copy Markdown
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Please use the PR branches from forked repos. :-)
In this case, posting to the repo branch was necessary to trigger the verification of the capz tests.

@vuil vuil merged commit 81d8bc1 into main Nov 30, 2021
@vuil vuil deleted the fix_telemetry branch November 30, 2021 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-not-required kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants