Skip to content

Spawn arrow conversion in jni bindings#8595

Merged
robert3005 merged 1 commit into
developfrom
rk/jnispawn
Jun 25, 2026
Merged

Spawn arrow conversion in jni bindings#8595
robert3005 merged 1 commit into
developfrom
rk/jnispawn

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

We want the worker pool to pick it up instead of running on the consuming thread

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 requested a review from a team June 25, 2026 15:49
@robert3005 robert3005 added the changelog/performance A performance improvement label Jun 25, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 4 improved benchmarks
❌ 3 regressed benchmarks
✅ 1582 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 15.9 µs 26.7 µs -40.29%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 169.1 µs 205.8 µs -17.83%
Simulation slice_empty_vortex 310 ns 368.3 ns -15.84%
Simulation chunked_varbinview_canonical_into[(100, 100)] 259.6 µs 224.5 µs +15.65%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation chunked_varbinview_into_canonical[(100, 100)] 306.8 µs 271.9 µs +12.84%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/jnispawn (7b63007) with develop (3493ecb)2

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (33d6e07) during the generation of this report, so 3493ecb was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@robert3005 robert3005 merged commit bdbf6c4 into develop Jun 25, 2026
80 of 82 checks passed
@robert3005 robert3005 deleted the rk/jnispawn branch June 25, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants