Skip to content

Spawn arrow conversion in jni bindings #8595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 1 commit into from
Jun 25, 2026
Merged

Spawn arrow conversion in jni bindings #8595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 23 additions & 15 deletions vortex-jni/src/scan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ use jni::objects::JClass;
use jni::objects::JLongArray;
use jni::sys::jboolean;
use jni::sys::jlong;
use vortex::array::ArrayRef;
use vortex::array::ExecutionCtx;
use vortex::array::VortexSessionExecute;
use vortex::array::arrow::ArrowSessionExt;
use vortex::array::stream::SendableArrayStream;
Expand All @@ -47,6 +45,7 @@ use vortex::scan::PartitionStream;
use vortex::scan::ScanRequest;
use vortex::scan::selection::Selection;

use crate::POOL;
use crate::RUNTIME;
use crate::data_source::NativeDataSource;
use crate::dtype::strip_views;
Expand Down Expand Up @@ -351,23 +350,32 @@ pub extern "system" fn Java_dev_vortex_jni_NativePartition_scanArrow(
_ => unreachable!("Vortex DType always exports as a struct"),
};
let schema = Arc::new(arrow_schema::Schema::new(fields));
let target = Field::new_struct("", schema.fields().clone(), false);
let target = Arc::new(Field::new_struct("", schema.fields().clone(), false));

let session = unsafe { session_ref(session_ptr) };

let iter = RUNTIME
.block_on_stream_thread_safe(|_handle| array_stream)
.map(
move |chunk: VortexResult<ArrayRef>| -> VortexResult<RecordBatch> {
let chunk: ArrayRef = chunk?;
let mut ctx: ExecutionCtx = session.create_execution_ctx();
let arrow = session
.arrow()
.execute_arrow(chunk, Some(&target), &mut ctx)?;
Ok(RecordBatch::from(arrow.as_struct().clone()))
},
)
.map(|result| result.map_err(|e| ArrowError::ExternalError(Box::new(e))));
.block_on_stream_thread_safe(|handle| {
array_stream
.map(move |chunk| {
let session = session.clone();
let target = Arc::clone(&target);
handle.spawn(async move {
let chunk = chunk?;
let mut ctx = session.create_execution_ctx();
let arrow = session.arrow().execute_arrow(
chunk,
Some(target.as_ref()),
&mut ctx,
)?;
Ok(RecordBatch::from(arrow.as_struct().clone()))
})
})
.buffered(POOL.worker_count().max(1))
})
.map(|result: VortexResult<RecordBatch>| {
result.map_err(|e| ArrowError::ExternalError(Box::new(e)))
});

let reader = RecordBatchIteratorAdapter::new(iter, schema);
let arrow_stream = FFI_ArrowArrayStream::new(Box::new(reader));
Expand Down
Loading