Skip to content

fix: REMARK element should be REMARKS#26

Merged
warappa merged 2 commits into
warappa:mainfrom
brendelphilipp:main
Apr 2, 2026
Merged

fix: REMARK element should be REMARKS#26
warappa merged 2 commits into
warappa:mainfrom
brendelphilipp:main

Conversation

@brendelphilipp
Copy link
Copy Markdown
Contributor

According to the bmecat2005 documentation and XSD, the element BMECAT/T_NEW_CATALOG/PRODUCT/REMARK should be named REMARKS

@warappa warappa merged commit 3d31608 into warappa:main Apr 2, 2026
@warappa
Copy link
Copy Markdown
Owner

warappa commented Apr 2, 2026

Hi @brendelphilipp,
good catch! Thanks for your contribution!

@warappa warappa added this to the 1.0.7 milestone Apr 2, 2026
@brendelphilipp
Copy link
Copy Markdown
Contributor Author

Thanks for creating this library, it saved me a lot of time already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants