Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions src/BMEcatSharp.Tests/BMEcatSerializationTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -269,4 +269,52 @@ public void Ticket17_Directly_set_Emails_property_is_serialized_even_if_not_acce
serializedContent.Should().Contain("email@example.com");
serializedContent.Should().Contain("email.2@example.com");
}

[Test]
public void PR26_RemarksHasRightElementName()
{
// Arrange
var order = testConfig.BMEcats.GetBMEcatNewCatalog();

var productDetails = new ProductDetails
{
DescriptionShort =
[
new MultiLingualString("test" , LanguageCodes.deu)
],
};

order.NewCatalog.Products.Add(new NewCatalogProduct
{
SupplierPid = new SupplierPid("123", SupplierPidTypeValues.Ean.ToString()),
OrderDetails = new ProductOrderDetails(),
PriceDetails =
[
new ProductPriceDetails
{
ProductPrices =
[
new ProductPrice()
{
Amount = 1m,
Type = ProductPriceTypeValues.GrosList
}
]
}
],

Details = productDetails
});

// Act
productDetails.Remarks =
[
new MultiLingualString("Product Details DE", LanguageCodes.deu),
new MultiLingualString("Product Details EN", LanguageCodes.eng)
];

// Assert
var validationResult = order.Validate(target);
validationResult.IsValid.Should().Be(true);
}
}
2 changes: 1 addition & 1 deletion src/BMEcatSharp/Types/ProductDetails.cs
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ public ProductDetails(IEnumerable<MultiLingualString> descriptionShort)
/// <br/>
/// XML-namespace: BMECAT
/// </summary>
[BMEXmlElement("REMARK")]
[BMEXmlElement("REMARKS")]
public List<MultiLingualString>? Remarks { get; set; } = [];
[EditorBrowsable(EditorBrowsableState.Never)]
public bool RemarksSpecified => Remarks?.Count > 0;
Expand Down