Set CMAKE_MODULE_PATH appropriately to always use preferred linalg-modules#38
Closed
ajaypanyala wants to merge 11 commits into
Closed
Set CMAKE_MODULE_PATH appropriately to always use preferred linalg-modules#38ajaypanyala wants to merge 11 commits into
ajaypanyala wants to merge 11 commits into
Conversation
wavefunction91
requested changes
Feb 10, 2021
Owner
|
@ajaypanyala Is there anything else you want to add to this? I'm going to hold off on merging until wavefunction91/linalg-cmake-modules#1 is merged |
Contributor
Author
|
I am done with my edits. Thanks! |
ajaypanyala
commented
Feb 12, 2021
| @@ -1,5 +1,5 @@ | |||
| set( GAUXC_LINALG_MODULES_REPOSITORY https://github.com/wavefunction91/linalg-cmake-modules.git ) | |||
| set( GAUXC_LINALG_MODULES_REVISION 89c82b78505f60657ef33b5bf38e5da059dff7f2 ) | |||
| set( GAUXC_LINALG_MODULES_REPOSITORY https://github.com/ajaypanyala/linalg-cmake-modules ) | |||
Contributor
Author
There was a problem hiding this comment.
Note before merging: This needs to change once wavefunction91/linalg-cmake-modules#1 is merged
ajaypanyala
commented
Feb 12, 2021
| set( GAUXC_LINALG_MODULES_REPOSITORY https://github.com/wavefunction91/linalg-cmake-modules.git ) | ||
| set( GAUXC_LINALG_MODULES_REVISION 89c82b78505f60657ef33b5bf38e5da059dff7f2 ) | ||
| set( GAUXC_LINALG_MODULES_REPOSITORY https://github.com/ajaypanyala/linalg-cmake-modules ) | ||
| set( GAUXC_LINALG_MODULES_REVISION main ) |
Contributor
Author
There was a problem hiding this comment.
TODO: Pin commit before merging.
Contributor
Author
|
am assuming this will be outdated soon. Will close it here and create a new PR later on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.