Tweaks after testing modules.#1
Merged
Merged
Conversation
wavefunction91
requested changes
Jan 4, 2021
…dules into ajaypanyala-main
wavefunction91
added a commit
to wavefunction91/blacspp
that referenced
this pull request
Feb 13, 2021
…de to solve problems with F* STOP return code
…n code to solve problems with F* STOP return code
* typo * replace FindTBB with the kitware version to be able to use with OneAPI MKL this also supports using the targets installed via a cmake-configured install of TBB (and prefers such targets) * explicitly link against C++ lib when using not only static but also pre-OneAPI _dynamic_ lib with TBB backend * move dependence on c++ stdlib into TBB::tbb target
* typo
* use dgesvd (instead of dpstrf) to detect linkage dependencies of lapack
on macos homebrew's openblas only some routines have dependence on fortran, dpstrf is not one of them
* typos
* consolidate check_{*}_exists into check_fortran_function_exists + for LAPACK test dpstrf AND dgesvd
* check_fortran_function_exists -> check_fortran_functions_exist to check for a set of functions at once
* detect silent compile errors in {blas,lapack}_check_int
* create genex-free linalg_<LANG>_COMPILE_OPTIONS that can be used in contexts (such as try_compile) where genex is not permitted
* factor unit tests
* do install util/BLASUtilities.cmake
* typo
* use dgesvd (instead of dpstrf) to detect linkage dependencies of lapack
on macos homebrew's openblas only some routines have dependence on fortran, dpstrf is not one of them
* typos
* consolidate check_{*}_exists into check_fortran_function_exists + for LAPACK test dpstrf AND dgesvd
* check_fortran_function_exists -> check_fortran_functions_exist to check for a set of functions at once
* detect silent compile errors in {blas,lapack}_check_int
* create genex-free linalg_<LANG>_COMPILE_OPTIONS that can be used in contexts (such as try_compile) where genex is not permitted
* factor unit tests
* do install util/BLASUtilities.cmake
* FORTRAN -> Fortran
* [CI] Force OpenBLAS GENERIC build in CI to avoid hangups
Co-authored-by: David Williams-Young <dbwy@lbl.gov>
Owner
|
@ajaypanyala It's clear neither of us have the cycles to polish this to the extent that we would like. Maybe we should just merge and work out future needs/wants in other PRs? |
Collaborator
Author
|
@wavefunction91 Sure. I do not have anything to add at this point too. Please go ahead and merge. |
wavefunction91
approved these changes
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.