Skip to content

Add Base64UrlSafe utility and refactor code references - #576

Merged
Spomky merged 3 commits into
3.4.xfrom
bugs/fix-missing-b64url-safe-class
Jul 2, 2024
Merged

Add Base64UrlSafe utility and refactor code references#576
Spomky merged 3 commits into
3.4.xfrom
bugs/fix-missing-b64url-safe-class

Conversation

@Spomky

@Spomky Spomky commented Jul 2, 2024

Copy link
Copy Markdown
Member

This commit adds the utility Base64UrlSafe to provide methods for encoding and decoding in Base64UrlSafe format. Simultaneously, the commit also updates multiple files across the library to use this utility instead of the previously used ParagonIE\ConstantTime\Base64UrlSafe. This change will ensure consistent use of this utility throughout the project, promoting maintainability and ease of updating in the future, if required.

Target branch:
Resolves issue #

  • It is a Bug fix
  • It is a New feature
  • It is related to dependencies

Includes:

  • Breaks BC
  • Deprecations

This commit adds the utility `Base64UrlSafe` to provide methods for encoding and decoding in Base64UrlSafe format. Simultaneously, the commit also updates multiple files across the library to use this utility instead of the previously used `ParagonIE\ConstantTime\Base64UrlSafe`. This change will ensure consistent use of this utility throughout the project, promoting maintainability and ease of updating in the future, if required.
@Spomky Spomky added the bug label Jul 2, 2024
@Spomky Spomky added this to the 3.4.5 milestone Jul 2, 2024
@Spomky Spomky self-assigned this Jul 2, 2024
Spomky added 2 commits July 2, 2024 18:07
This commit adds the utility `Base64UrlSafe` to provide methods for encoding and decoding in Base64UrlSafe format. Simultaneously, the commit also updates multiple files across the library to use this utility instead of the previously used `ParagonIE\ConstantTime\Base64UrlSafe`. This change will ensure consistent use of this utility throughout the project, promoting maintainability and ease of updating in the future, if required.
This commit adds the utility `Base64UrlSafe` to provide methods for encoding and decoding in Base64UrlSafe format. Simultaneously, the commit also updates multiple files across the library to use this utility instead of the previously used `ParagonIE\ConstantTime\Base64UrlSafe`. This change will ensure consistent use of this utility throughout the project, promoting maintainability and ease of updating in the future, if required.
@Spomky
Spomky merged commit 1fe7ca8 into 3.4.x Jul 2, 2024
@Spomky
Spomky deleted the bugs/fix-missing-b64url-safe-class branch July 2, 2024 16:12
}
}
if (($srcLen & 3) === 1) {
throw new RangeException('Incorrect padding');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attempted to load class "RangeException" from namespace "Jose\Component\Core\Util".
Did you forget a "use" statement for another namespace?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

This should be fixed with the last bug release.

wheakerd pushed a commit to wheakerd/jwt-framework that referenced this pull request Jun 7, 2026
* 3.4.x:
  Update signature tests for the protected-header "alg" requirement (web-token#651)
  Merge commit from fork
  Merge commit from fork
  Merge commit from fork
  Merge commit from fork
  Add sodium support for Base64 URL safe encoding/decoding (web-token#644)
  Allow `psr/cache` v2 (web-token#620)
  Fix call function on null (web-token#596)
  Add RangeException to Base64UrlSafe (web-token#577)
  Add Base64UrlSafe utility and refactor code references (web-token#576)

# Conflicts:
#	composer.json
#	phpstan-baseline.neon
#	src/Bundle/DataCollector/JWECollector.php
#	src/Experimental/KeyEncryption/AESCTR.php
#	src/Experimental/KeyEncryption/Chacha20Poly1305.php
#	src/Experimental/Signature/Blake2b.php
#	src/Library/Console/GeneratorCommand.php
#	src/Library/Core/JWK.php
#	src/Library/Core/Util/Base64UrlSafe.php
#	src/Library/Encryption/Algorithm/ContentEncryption/AESCBCHS.php
#	src/Library/Encryption/Algorithm/ContentEncryption/AESGCM.php
#	src/Library/Encryption/Algorithm/KeyEncryption/AESGCMKW.php
#	src/Library/Encryption/Algorithm/KeyEncryption/AESKW.php
#	src/Library/Encryption/Algorithm/KeyEncryption/AbstractECDH.php
#	src/Library/Encryption/Algorithm/KeyEncryption/Dir.php
#	src/Library/Encryption/Algorithm/KeyEncryption/PBES2AESKW.php
#	src/Library/Encryption/Algorithm/KeyEncryption/RSA15.php
#	src/Library/Encryption/Algorithm/KeyEncryption/Util/ConcatKDF.php
#	src/Library/Encryption/Algorithm/KeyEncryption/Util/RSACrypt.php
#	src/Library/Encryption/Serializer/CompactSerializer.php
#	src/Library/Encryption/Serializer/JSONFlattenedSerializer.php
#	src/Library/Encryption/Serializer/JSONGeneralSerializer.php
#	src/Library/KeyManagement/Analyzer/ESKeyAnalyzer.php
#	src/Library/KeyManagement/Analyzer/HSKeyAnalyzer.php
#	src/Library/KeyManagement/Analyzer/OctAnalyzer.php
#	src/Library/KeyManagement/Analyzer/RsaAnalyzer.php
#	src/Library/KeyManagement/Analyzer/ZxcvbnKeyAnalyzer.php
#	src/Library/Signature/Algorithm/EdDSA.php
#	src/Library/Signature/Algorithm/HMAC.php
#	src/Library/Signature/Serializer/CompactSerializer.php
#	src/Library/Signature/Serializer/JSONFlattenedSerializer.php
#	src/Library/Signature/Serializer/JSONGeneralSerializer.php
#	src/Library/composer.json
#	tests/Bundle/JoseFramework/Functional/Encryption/JWECollectorTest.php
#	tests/Bundle/JoseFramework/Functional/KeyManagement/JWKLoaderTest.php
#	tests/Component/Encryption/RFC7520/A128KWAndA128GCMEncryptionWithCompressionTest.php
#	tests/Component/KeyManagement/JWKFactoryTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants