Skip to content

Allow psr/cache v2 - #620

Merged
Spomky merged 2 commits into
web-token:3.4.xfrom
jdreesen:patch-1
May 7, 2025
Merged

Allow psr/cache v2#620
Spomky merged 2 commits into
web-token:3.4.xfrom
jdreesen:patch-1

Conversation

@jdreesen

@jdreesen jdreesen commented May 6, 2025

Copy link
Copy Markdown
Contributor

Target branch: 3.4.x

  • It is a Bug fix
  • It is a New feature
  • It is related to dependencies

Includes:

  • Breaks BC
  • Deprecations

Allow psr/cache v2 to be compatible with symfony/cache ^5.4 which only allows psr/cache ^1.0|^2.0 (see: https://github.com/symfony/cache/blob/5.4/composer.json#L25)

@jdreesen

jdreesen commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

Pipeline failures don't seem to be related 🤔

@Spomky Spomky added this to the 3.3.6 milestone May 7, 2025
@Spomky Spomky added the Dependencies Pull requests that update a dependency file label May 7, 2025
@Spomky

Spomky commented May 7, 2025

Copy link
Copy Markdown
Member

Pipeline failures don't seem to be related 🤔

No worries about the failing pipeline.
Could you please target 3.3.x and rebase? I will tag as 3.3.6 instead of 3.4.0 as there is no new feature.

@jdreesen

jdreesen commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

But the PR that added psr/cache as a dependency (#550) was released as 3.4.0. So I would have expected 3.4.8 to be the next version with this fix 🤔

@Spomky Spomky modified the milestones: 3.3.6, 3.4.8 May 7, 2025
@Spomky

Spomky commented May 7, 2025

Copy link
Copy Markdown
Member

Indeed 😅. So let merge and tag.

@Spomky
Spomky merged commit 7882670 into web-token:3.4.x May 7, 2025
@jdreesen
jdreesen deleted the patch-1 branch May 7, 2025 09:34
@jdreesen

jdreesen commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

@Spomky it seems like the gitsplit action didn't run, so the https://github.com/web-token/jwt-library repo wasn't updated and the new 3.4.8 tag doesn't show up in https://packagist.org/packages/web-token/jwt-library, which means I cannot use it.

Can you please have a look?

@Spomky

Spomky commented May 7, 2025

Copy link
Copy Markdown
Member

I manually split the branch. This should be fixed now.

@jdreesen

jdreesen commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

Great, now it is available. Thank you very much!

wheakerd pushed a commit to wheakerd/jwt-framework that referenced this pull request Jun 7, 2026
* 3.4.x:
  Update signature tests for the protected-header "alg" requirement (web-token#651)
  Merge commit from fork
  Merge commit from fork
  Merge commit from fork
  Merge commit from fork
  Add sodium support for Base64 URL safe encoding/decoding (web-token#644)
  Allow `psr/cache` v2 (web-token#620)
  Fix call function on null (web-token#596)
  Add RangeException to Base64UrlSafe (web-token#577)
  Add Base64UrlSafe utility and refactor code references (web-token#576)

# Conflicts:
#	composer.json
#	phpstan-baseline.neon
#	src/Bundle/DataCollector/JWECollector.php
#	src/Experimental/KeyEncryption/AESCTR.php
#	src/Experimental/KeyEncryption/Chacha20Poly1305.php
#	src/Experimental/Signature/Blake2b.php
#	src/Library/Console/GeneratorCommand.php
#	src/Library/Core/JWK.php
#	src/Library/Core/Util/Base64UrlSafe.php
#	src/Library/Encryption/Algorithm/ContentEncryption/AESCBCHS.php
#	src/Library/Encryption/Algorithm/ContentEncryption/AESGCM.php
#	src/Library/Encryption/Algorithm/KeyEncryption/AESGCMKW.php
#	src/Library/Encryption/Algorithm/KeyEncryption/AESKW.php
#	src/Library/Encryption/Algorithm/KeyEncryption/AbstractECDH.php
#	src/Library/Encryption/Algorithm/KeyEncryption/Dir.php
#	src/Library/Encryption/Algorithm/KeyEncryption/PBES2AESKW.php
#	src/Library/Encryption/Algorithm/KeyEncryption/RSA15.php
#	src/Library/Encryption/Algorithm/KeyEncryption/Util/ConcatKDF.php
#	src/Library/Encryption/Algorithm/KeyEncryption/Util/RSACrypt.php
#	src/Library/Encryption/Serializer/CompactSerializer.php
#	src/Library/Encryption/Serializer/JSONFlattenedSerializer.php
#	src/Library/Encryption/Serializer/JSONGeneralSerializer.php
#	src/Library/KeyManagement/Analyzer/ESKeyAnalyzer.php
#	src/Library/KeyManagement/Analyzer/HSKeyAnalyzer.php
#	src/Library/KeyManagement/Analyzer/OctAnalyzer.php
#	src/Library/KeyManagement/Analyzer/RsaAnalyzer.php
#	src/Library/KeyManagement/Analyzer/ZxcvbnKeyAnalyzer.php
#	src/Library/Signature/Algorithm/EdDSA.php
#	src/Library/Signature/Algorithm/HMAC.php
#	src/Library/Signature/Serializer/CompactSerializer.php
#	src/Library/Signature/Serializer/JSONFlattenedSerializer.php
#	src/Library/Signature/Serializer/JSONGeneralSerializer.php
#	src/Library/composer.json
#	tests/Bundle/JoseFramework/Functional/Encryption/JWECollectorTest.php
#	tests/Bundle/JoseFramework/Functional/KeyManagement/JWKLoaderTest.php
#	tests/Component/Encryption/RFC7520/A128KWAndA128GCMEncryptionWithCompressionTest.php
#	tests/Component/KeyManagement/JWKFactoryTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants