This repository was archived by the owner on Mar 5, 2025. It is now read-only.
subscription.js Emit 'connected' event with subscription.id#3028
Conversation
lbertenasco
changed the title
nivida
added
1.x
nivida
suggested changes
Oct 15, 2019
Contributor
nivida
left a comment
nivida
left a comment
There was a problem hiding this comment.
Thanks for proposing this PR! Could you please update the changelog file located in the root folder of this branch? and also extend the documentation?
Contributor
Author
Changelog and docs updated 👍 |
nivida
approved these changes
Oct 17, 2019
This was referenced Mar 31, 2020
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* Update subscription.js * Updates Changelog and Docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would something like this be possible to add?
It's useful when testing WS subscriptions successful connections.
Instead of retrying get
subscription.iduntil it's defined.