This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Auto fetch tx signing option values when not set by user#3143
Merged
nivida merged 11 commits intoweb3:issue/new-signing-parametersfrom Oct 21, 2019
cgewecke:issue/signing-params-autofetch
Merged
Auto fetch tx signing option values when not set by user#3143nivida merged 11 commits intoweb3:issue/new-signing-parametersfrom cgewecke:issue/signing-params-autofetch
nivida merged 11 commits intoweb3:issue/new-signing-parametersfrom
cgewecke:issue/signing-params-autofetch
Conversation
cgewecke
commented
Oct 18, 2019
cgewecke
commented
Oct 18, 2019
cgewecke
commented
Oct 18, 2019
nivida
added
1.x
nivida
suggested changes
Oct 19, 2019
Contributor
nivida
left a comment
nivida
left a comment
There was a problem hiding this comment.
If there is no veto from your side will I do the commented changes today or tomorrow (Sunday)
nivida
approved these changes
Oct 21, 2019
nivida
added a commit
that referenced
this pull request
Oct 21, 2019
* signTransaction updated, getId method in net module, and e2e signTransaction method updated * types and documentation for accounts.signTransaction updated * example for custom common added * CHANGELOG.md updated and url added to accounts.signTransaction documentation * error msg improved * web3-eth sendTransaction documentation updated * parameter validation updated for accounts.signTransaction method * Auto fetch tx signing option values when not set by user (#3143) * public api simplified if someone wants to pass custom chain configuration (ethereumjs-common) * default properties added (chain, hardfork, and common) and related types updated * documentation updated for new default properties * typo fixed in docs and conditions for the new default properties updated in the Method class of the web3-core-method module * funcDocs fixed in utils and missing option properties added in the web3-eth-contract module
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* signTransaction updated, getId method in net module, and e2e signTransaction method updated * types and documentation for accounts.signTransaction updated * example for custom common added * CHANGELOG.md updated and url added to accounts.signTransaction documentation * error msg improved * web3-eth sendTransaction documentation updated * parameter validation updated for accounts.signTransaction method * Auto fetch tx signing option values when not set by user (web3#3143) * public api simplified if someone wants to pass custom chain configuration (ethereumjs-common) * default properties added (chain, hardfork, and common) and related types updated * documentation updated for new default properties * typo fixed in docs and conditions for the new default properties updated in the Method class of the web3-core-method module * funcDocs fixed in utils and missing option properties added in the web3-eth-contract module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB: MERGE TARGET is #3141
Per @nivida's idea from a chat, adds auto-fetching of custom network details when using
eth.accounts.signTransaction. Idea is to extend #3141 so its new behavior does not require people to add ethereumjs-custom options when using non-mainnet chains.Adds tests for:
[Edit - WIP while fixing the unit mocks....]