Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Correct web3-eth2-beaconchain typings - #3859

Merged
Spacesai1or merged 4 commits into
1.xfrom
wyatt/beaconchain-typings
Jan 18, 2021
Merged

Correct web3-eth2-beaconchain typings#3859
Spacesai1or merged 4 commits into
1.xfrom
wyatt/beaconchain-typings

Conversation

@Spacesai1or

Copy link
Copy Markdown
Contributor

Description

Corrects the typings for the web3-eth2-beaconchain package

Fixes #3843

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@GregTheGreek GregTheGreek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just re-exporting all the lodestar types?

@Spacesai1or

Copy link
Copy Markdown
Contributor Author

Just re-exporting all the lodestar types?

Unfortunately, but not sure how else to type the package since all the methods exist as a JSON schema

@Spacesai1or

Spacesai1or commented Jan 18, 2021

Copy link
Copy Markdown
Contributor Author

Forgot to @GregTheGreek ^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement correct type declarations for web3-eth2-beaconchain

2 participants