This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Correct web3-eth2-beaconchain typings - #3859
Merged
Merged
Conversation
GregTheGreek
left a comment
Contributor
There was a problem hiding this comment.
Just re-exporting all the lodestar types?
Contributor
Author
Unfortunately, but not sure how else to type the package since all the methods exist as a JSON schema |
Contributor
Author
|
Forgot to @GregTheGreek ^ |
GregTheGreek
approved these changes
Jan 18, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects the typings for the
web3-eth2-beaconchainpackageFixes #3843
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.