Release 1.3.4-rc.2 by Spacesai1or · Pull Request #3885 · web3/web3.js

Spacesai1or · 2021-01-26T01:12:23Z

This release contains bug fixes, updates dependencies (including 4 security vulnerabilities), adds deprecation notice for web3-bzz, and updates the Typescript types for web3-eth2-core and web3-eth2-beaconchain

Changed

Fixed mutation of inputs to encoding and decoding functions (ABI objects passed into web3 functions may end up mutated #3748)
Fix default value for fromBlock option for logs subscriptions (defaults to latest) (Wyatt/3882 log subscription #3883)
ethjs-signer test (remove ethjs-signer from project #3876)
Rename web3-eth2-base to web3-eth2-core and web3-eth2-beacon to web3-eth2-beaconchain (Rename eth2 packages #3833)
Bump ts-node from version ^8.10.2 to ^9.0.0 (Update ts-node to ^9.0.0 and ran npm audit fix #3856)
Ran npm audit fix which fixed 4 vulnerabilities (Update ts-node to ^9.0.0 and ran npm audit fix #3856)
Correct web3-eth2-beaconchain type declarations (Correct web3-eth2-beaconchain typings #3859) and (Correct web3-eth2- packages types #3865)
Move interfaces IBaseAPISchema and IBaseAPIMethodSchema to index.d.ts for web3-eth2-core (ETH2 packages types fix #3878)
Update dependencies for web3-eth2-core (ETH2 packages types fix #3878)

Removed

Remove notImplemented flag from ETH2 Beacon Chain package methods schema (Release/1.3.2 #3861)
Removes IETH2BeaconChain interface in favor of exporting a class type: ETH2BeaconChain (ETH2 packages types fix #3878)
Remove index.d.ts files in favor of types.ts for web3-eth2-core and web3-eth2-beaconchain (ETH2 packages types fix #3878)
schema.ts from web3-eth2-core (ETH2 packages types fix #3878)
dtslint npm command from web3-eth2-core and web3-eth2-beaconchain as index.d.ts files were removed (ETH2 packages types fix #3878)

Added

Add ETH2Core class export to index.d.ts for web3-eth2-core (ETH2 packages types fix #3878)
Deprecation of bzz warning (add depreciation warning #3872)

coveralls · 2021-01-26T01:27:35Z

Pull Request Test Coverage Report for Build 534261530

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.767%

Totals
Change from base Build 528837041:	0.0%
Covered Lines:	3294
Relevant Lines:	4225

💛 - Coveralls

GregTheGreek

~~LGTM will start the npm release~~
Build didn't work

GregTheGreek

RC LGTM

Spacesai1or · 2021-01-27T18:15:36Z

Ran using 1.3.4-rc.1

Replicating the steps mentioned in previous releases

As part of the RC process, am doing some test installations in other projects and running their tests to see if everything.

installs properly
builds
tests pass

(This list will be actively edited)

Project	Desc	Status
oz-test-helpers	Test utils. Subset of their suite is web3 contracts	✔️
synthetix	~1000 units	❌

Synthetic tests failed with same JavaScript heap out of memory as last release:

  Contract: Exchange Rates
    when integrating with modern contracts
      ✓ only expected functions should be mutative
      constructor
        ✓ should set constructor params on deployment (107ms)
        ✓ two different currencies in same array should mean that the second one overrides (125ms)
        ✓ should revert when number of currency keys > new rates length on create (97ms)
        ✓ should limit to 32 bytes if currency key > 32 bytes on create (115ms)
        ✓ shouldn't be able to set exchange rate to 0 on create (98ms)

<--- Last few GCs --->

[26170:0x4426ef0]   697444 ms: Scavenge 1346.2 (1395.4) -> 1345.2 (1395.4) MB, 2.9 / 0.0 ms  (average mu = 0.187, current mu = 0.130) allocation failure 
[26170:0x4426ef0]   697455 ms: Scavenge 1352.7 (1402.0) -> 1351.7 (1402.0) MB, 3.5 / 0.0 ms  (average mu = 0.187, current mu = 0.130) allocation failure 
[26170:0x4426ef0]   697464 ms: Scavenge 1358.3 (1407.7) -> 1357.4 (1407.7) MB, 3.4 / 0.0 ms  (average mu = 0.187, current mu = 0.130) allocation failure 


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x3bd63389e6e9 <JSObject>
    0: builtin exit frame: concat(this=0x234376382799 <JSArray[82432]>,0x234376382df1 <JSArray[32]>,0x234376382799 <JSArray[82432]>)

    1: MSTORE(aka MSTORE) [0x171942ab16f9] [/home/anon/tmp/synthetix/node_modules/@nomiclabs/ethereumjs-vm/dist/evm/opFns.js:~445] [pc=0x3a2909f701a8](this=0x330780d022b1 <null>,runState=0x2450cad13189 <Object map = 0xabd67fee731>)
    2: runStep [0x171942a9bcd9] ...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8fa090 node::Abort() [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 2: 0x8fa0dc  [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 3: 0xb0052e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 4: 0xb00764 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 5: 0xef4c72  [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 6: 0xef4d78 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 7: 0xf00e52 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 8: 0xf01784 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 9: 0xf043f1 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
10: 0xecd4e6 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
11: 0xecdd6a v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
12: 0xeda751 v8::internal::Factory::NewJSArrayStorage(v8::internal::Handle<v8::internal::JSArray>, int, int, v8::internal::ArrayStorageAllocationMode) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
13: 0xedaa4c v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
14: 0xe93e81 v8::internal::ElementsAccessor::Concat(v8::internal::Isolate*, v8::internal::Arguments*, unsigned int, unsigned int) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
15: 0xb8fcc9  [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
16: 0xb993c8 v8::internal::Builtin_ArrayConcat(int, v8::internal::Object**, v8::internal::Isolate*) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
17: 0x3a290535bf7d 
Aborted (core dumped)
error Command failed with exit code 134.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Spacesai1or · 2021-02-01T21:08:48Z

Ran using 1.3.4-rc.2

Replicating the steps mentioned in previous releases

As part of the RC process, am doing some test installations in other projects and running their tests to see if everything.

installs properly
builds
tests pass

(This list will be actively edited)

Project	Desc	Status
oz-test-helpers	Test utils. Subset of their suite is web3 contracts	✔️
synthetix	~1000 units	❌

Synthetic tests failed with same JavaScript heap out of memory as last release:

  Contract: Exchange Rates
    when integrating with modern contracts
      ✓ only expected functions should be mutative
      constructor
        ✓ should set constructor params on deployment (419ms)
        ✓ two different currencies in same array should mean that the second one overrides (159ms)
        ✓ should revert when number of currency keys > new rates length on create (109ms)
        ✓ should limit to 32 bytes if currency key > 32 bytes on create (123ms)
        ✓ shouldn't be able to set exchange rate to 0 on create (109ms)

<--- Last few GCs --->

[10670:0x34cdef0]   698038 ms: Scavenge 1345.9 (1397.1) -> 1344.9 (1397.1) MB, 2.4 / 0.0 ms  (average mu = 0.176, current mu = 0.130) allocation failure 
[10670:0x34cdef0]   698047 ms: Scavenge 1352.2 (1403.5) -> 1351.2 (1403.5) MB, 2.7 / 0.0 ms  (average mu = 0.176, current mu = 0.130) allocation failure 
[10670:0x34cdef0]   698055 ms: Scavenge 1357.9 (1409.3) -> 1356.9 (1409.3) MB, 2.4 / 0.0 ms  (average mu = 0.176, current mu = 0.130) allocation failure 


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x090565e1e6e9 <JSObject>
    0: builtin exit frame: concat(this=0x0fd892782271 <JSArray[83168]>,0x0fd892782929 <JSArray[32]>,0x0fd892782271 <JSArray[83168]>)

    1: MSTORE(aka MSTORE) [0xccc7979ac69] [/home/anon/tmp/synthetix/node_modules/@nomiclabs/ethereumjs-vm/dist/evm/opFns.js:~445] [pc=0x2d6205dc9da8](this=0x0904365822b1 <null>,runState=0x2c130d4d8331 <Object map = 0x16881acb98e1>)
    2: runStep [0xccc79786601] [...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8fa090 node::Abort() [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 2: 0x8fa0dc  [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 3: 0xb0052e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 4: 0xb00764 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 5: 0xef4c72  [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 6: 0xef4d78 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 7: 0xf00e52 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 8: 0xf01784 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
 9: 0xf043f1 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
10: 0xecd4e6 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
11: 0xecdd6a v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
12: 0xeda751 v8::internal::Factory::NewJSArrayStorage(v8::internal::Handle<v8::internal::JSArray>, int, int, v8::internal::ArrayStorageAllocationMode) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
13: 0xedaa4c v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
14: 0xe93e81 v8::internal::ElementsAccessor::Concat(v8::internal::Isolate*, v8::internal::Arguments*, unsigned int, unsigned int) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
15: 0xb8fcc9  [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
16: 0xb993c8 v8::internal::Builtin_ArrayConcat(int, v8::internal::Object**, v8::internal::Isolate*) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
17: 0x2d62011dbf7d 
Aborted (core dumped)
error Command failed with exit code 134.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

frankiebee

🎉

Spacesai1or added 2 commits January 25, 2021 19:06

RC process

88df973

v1.3.4-rc.0

6aba292

Spacesai1or requested review from GregTheGreek, frankiebee and koraykoska January 26, 2021 01:12

GregTheGreek reviewed Jan 26, 2021

View reviewed changes

Spacesai1or added 2 commits January 25, 2021 22:05

Built dist for 1.3.4

3dad4da

v1.3.4-rc.1

0b86ab7

Spacesai1or changed the title ~~Release 1.3.4.rc-0~~ Release 1.3.4.rc-1 Jan 26, 2021

GregTheGreek reviewed Jan 26, 2021

View reviewed changes

Spacesai1or added 3 commits January 28, 2021 16:20

Merge branch '1.x' into release/1.3.4

0adaf22

Built dist

0280051

v1.3.4-rc.2

f72f828

Spacesai1or changed the title ~~Release 1.3.4.rc-1~~ Release 1.3.4-rc.2 Feb 1, 2021

Spacesai1or mentioned this pull request Feb 1, 2021

Wyatt/eth2 GitHub action #3896

Merged

GregTheGreek and others added 3 commits February 3, 2021 09:59

v1.3.4

a4840c3

commit binary

91e42f8

Merge branch '1.x' into release/1.3.4

f6d60bd

frankiebee approved these changes Feb 3, 2021

View reviewed changes

GregTheGreek merged commit 60b30b8 into 1.x Feb 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release 1.3.4-rc.2 - #3885

Release 1.3.4-rc.2#3885
GregTheGreek merged 10 commits into
1.xfrom
release/1.3.4

Spacesai1or commented Jan 26, 2021

Uh oh!

coveralls commented Jan 26, 2021 •

edited

Loading

Uh oh!

GregTheGreek left a comment •

edited

Loading

Uh oh!

GregTheGreek left a comment

Uh oh!

Spacesai1or commented Jan 27, 2021 •

edited

Loading

Uh oh!

Spacesai1or commented Feb 1, 2021

Uh oh!

frankiebee left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Spacesai1or commented Jan 26, 2021

Changed

Removed

Added

Uh oh!

coveralls commented Jan 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 534261530

💛 - Coveralls

Uh oh!

GregTheGreek left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GregTheGreek left a comment

Choose a reason for hiding this comment

Uh oh!

Spacesai1or commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Spacesai1or commented Feb 1, 2021

Uh oh!

frankiebee left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Jan 26, 2021 •

edited

Loading

GregTheGreek left a comment •

edited

Loading

Spacesai1or commented Jan 27, 2021 •

edited

Loading