Skip to content

Fix updater runtime error state#161

Merged
bearyung merged 1 commit into
mainfrom
agent/fix-updater-runtime-error-state
Jul 15, 2026
Merged

Fix updater runtime error state#161
bearyung merged 1 commit into
mainfrom
agent/fix-updater-runtime-error-state

Conversation

@bearyung

Copy link
Copy Markdown
Collaborator

Summary

  • remove a managed runtime provider's stale error key after a successful install
  • treat only non-empty runtime error messages as failed checks in updater state and the Updates dialog
  • add regression coverage for the current-state transition and two-provider error preservation

Root cause

Successful runtime installation assigned undefined to the provider entry in runtimeErrors. The Updates dialog checked only the number of object keys, so the stale key produced a false "Some update checks failed" state while rendering no provider-specific warning.

User impact

After installing managed Codex or Claude runtime updates, the dialog now immediately reports the correct current state. A genuine error for the other provider remains visible.

Validation

  • npx vitest run src/lib/state/updater.test.ts
  • npm run check
  • npm test
  • npm run build
  • git diff --check

@bearyung
bearyung marked this pull request as ready for review July 15, 2026 13:26
@bearyung
bearyung merged commit 4dea5d8 into main Jul 15, 2026
3 checks passed
@bearyung
bearyung deleted the agent/fix-updater-runtime-error-state branch July 15, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant