#1200 Retire mcp's lint deferrals and prune the dead root entries - #1205
Merged
Conversation
The stale-build warning latches per server rather than per process, so each server reports a stale build once on its own first tool call.
Each fake package directory is created by the OS with a guaranteed-unique name, so concurrent runs of the staleness suite cannot collide.
The four unicorn rules the package deferred to warnings now fail the build, and the package declares no lint ceilings of its own, inheriting the repo-wide ones.
Three unicorn rules that root-level files no longer violate fail the build instead of warning.
Dependency auditProduction dependency audit passed. |
williamthorsen
marked this pull request as ready for review
August 5, 2026 16:14
williamthorsen
added a commit
that referenced
this pull request
Aug 7, 2026
…ssembly-mcp-v0.2.4 codeassembly-v0.6.0 codeassembly-v0.6.0 - #794 feat: Guide kb-add note placement with the store's declared taxonomy (#1223) - #1111 feat: Declare which harnesses sync targets (#1221) - #1214 feat: Allow an artifact to belong to more than one collection (#1219) - #1186 drop!: Dissolve `common-mistakes` into its consumers' guidance (#1217) - deps: Upgrade all deps to latest version - #1203 fix: Bar acceptance-criteria revision prompts to genuine conflicts (#1212) - #1196 feat: Add the .kb/taxonomy.yaml format with drift reporting and back-fill (#1210) - #1165 feat: Make a vetted subset of the library declarable (#1207) - #1197 feat: Report the retired `harnesses:` frontmatter key from `validate` (#1204) - #963 feat!: Rename the harness id to rovo and qualify the frontmatter key (#1199) - #1188 drop!: Retire the bundled Bitbucket inline-comment script (#1198) - #1187 feat: Gate the boolean prefix on a test and add the tail rule it rests on (#1195) factory-v0.2.4 - deps: Upgrade all deps to latest version - deps: Upgrade all deps to latest version - #1209 refactor: Clear factory's remaining lint violations and retire both deferral lists (#1216) - #1208 refactor: Clear the visualizations lint violations and retire six rule deferrals (#1213) kb-v0.4.0 - #794 feat: Guide kb-add note placement with the store's declared taxonomy (#1223) - #1196 feat: Add the .kb/taxonomy.yaml format with drift reporting and back-fill (#1210) codeassembly-lifecycle-v0.3.0 - #963 feat!: Rename the harness id to rovo and qualify the frontmatter key (#1199) codeassembly-mcp-v0.2.4 - #1206 refactor: Retire fleet's lint deferrals (#1211) - #1200 tooling: Retire mcp's lint deferrals and prune the dead root entries (#1205)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes deferred lint violations in the MCP package and restores the severity of the associated rules to "error" when a strict-lint check is run.
Why
The mcp package downgraded four unicorn rules to warnings, so 11 real violations sat unaddressed and any new one would have joined them unnoticed. Three entries in the repo-root list suppressed nothing at all, leaving the list a misleading record of what the repo actually defers.
Details
♻️ Refactoring
createStaleWarningGate(), making it per server instance. The eager set before the async staleness check is preserved, so concurrent tool calls still emit at most one warning.server.close()insidetry/catchin place of a trailing.catch().🧪 Tests
mkdtemp, which gives the OS-guaranteed uniqueness the module-level counter was approximating.⚠️regex literals in the staleness suite use\u{…}code point escapes with theuflag.splice(0).⚙️ Tooling
packages/mcp/.config/is gone: both the ESLint deferral list and the strict-lint config whose only job was consuming it.packages/mcp/eslint.config.tsreduces to the base config plus its ignore list. The package inherits the root ceilings, which bound promotion of a warning and leave a rule the ESLint config sets toerroraterror.unicorn/no-computed-property-existence-check,unicorn/no-top-level-side-effects, andunicorn/prefer-await. The two retained rules cover 12 live warnings, all indemos/catwalk/scenarios.js.Closes #1200