#1206 Retire fleet's lint deferrals - #1211
Merged
Merged
Conversation
Clears five of the seventeen lint violations that fleet's deferral list suppresses.
Clears the two `unicorn/no-unnecessary-splice` findings that fleet's deferral list suppresses.
Clears one `unicorn/no-top-level-assignment-in-function` finding that fleet's deferral list suppresses. The suite's helpers also move below the describe block, per the repo's test-file layout convention.
Clears six `unicorn/no-top-level-assignment-in-function` findings that fleet's deferral list suppresses. The suite's helpers also move below the describe blocks and into alphabetical order, per the repo's test-file layout convention.
Clears the last three `unicorn/no-top-level-assignment-in-function` findings that fleet's deferral list suppresses. Each test now holds its own server and events root, and the suite's helpers move below the describe block, per the repo's test-file layout convention.
Fleet's six deferred unicorn rules are back at their default `error` severity, so a new violation fails lint rather than passing as a warning.
Brings the suite into line with the repo's test-file layout convention, which fleet's other touched suites already follow.
A server that fails to stop now fails its test instead of being dropped silently during teardown. Each suite registers cleanup where the resource is created, so teardown runs in reverse creation order and no suite carries a registry of its own.
Both packages' `tsconfig.json` named a `.config/` tree neither package has, matching nothing while asserting a directory that is gone.
williamthorsen
added
refactoring
Dependency auditProduction dependency audit passed. |
williamthorsen
marked this pull request as ready for review
August 5, 2026 22:33
williamthorsen
added a commit
that referenced
this pull request
Aug 7, 2026
…ssembly-mcp-v0.2.4 codeassembly-v0.6.0 codeassembly-v0.6.0 - #794 feat: Guide kb-add note placement with the store's declared taxonomy (#1223) - #1111 feat: Declare which harnesses sync targets (#1221) - #1214 feat: Allow an artifact to belong to more than one collection (#1219) - #1186 drop!: Dissolve `common-mistakes` into its consumers' guidance (#1217) - deps: Upgrade all deps to latest version - #1203 fix: Bar acceptance-criteria revision prompts to genuine conflicts (#1212) - #1196 feat: Add the .kb/taxonomy.yaml format with drift reporting and back-fill (#1210) - #1165 feat: Make a vetted subset of the library declarable (#1207) - #1197 feat: Report the retired `harnesses:` frontmatter key from `validate` (#1204) - #963 feat!: Rename the harness id to rovo and qualify the frontmatter key (#1199) - #1188 drop!: Retire the bundled Bitbucket inline-comment script (#1198) - #1187 feat: Gate the boolean prefix on a test and add the tail rule it rests on (#1195) factory-v0.2.4 - deps: Upgrade all deps to latest version - deps: Upgrade all deps to latest version - #1209 refactor: Clear factory's remaining lint violations and retire both deferral lists (#1216) - #1208 refactor: Clear the visualizations lint violations and retire six rule deferrals (#1213) kb-v0.4.0 - #794 feat: Guide kb-add note placement with the store's declared taxonomy (#1223) - #1196 feat: Add the .kb/taxonomy.yaml format with drift reporting and back-fill (#1210) codeassembly-lifecycle-v0.3.0 - #963 feat!: Rename the harness id to rovo and qualify the frontmatter key (#1199) codeassembly-mcp-v0.2.4 - #1206 refactor: Retire fleet's lint deferrals (#1211) - #1200 tooling: Retire mcp's lint deferrals and prune the dead root entries (#1205)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes deferred lint violations in the
fleetpackage and restores the severity of the associated rules to "error" when a strict-lint check is run.Why
Fleet's own deferral list downgraded six unicorn rules to warnings and pinned a strict-lint ceiling that kept them from being promoted back, so violations passed both
lint:checkandlint:strictunchallenged. Seventeen had accumulated behind that gap, and nothing stopped new code from adding more.Details
♻️ Refactoring
git.tsextracts aprobeOrDegradehelper in place of.catch()on the injected probe, which also closes a latent gap: a probe that throws synchronously now degrades to an unanswered observation instead of escaping as an unhandled rejection.git.tsfolds threebranch === …comparisons into aNO_BRANCH_OUTPUTSset, matching the doc comment that already treated them as one condition, and reads ahead/behind counts throughNumber.isSafeInteger.event-store.tsbuildslistLanesfrom an iterator chain rather than a spread-then-map.🧪 Tests
letstate assigned inbeforeEachwith helpers that create a resource and register its teardown throughonTestFinished, so a test cannot allocate a temp directory, adapter, or server without arranging its cleanup. Reverse-ordered teardown stops each server before the events root beneath it is removed.describeblock into// region | Helpers, matching the suites that already followed that order.⚙️ Tooling
packages/fleet/.config/is deleted andeslint.config.tsreduces to a pass-through over the root config, restoring the six rules to their defaulterrorseverity.packages/fleet/tsconfig.jsonandpackages/mcp/tsconfig.jsondrop anincludeglob naming a.config/tree neither package still has.The repo-root deferral list keeps both of its entries, which retain violations in
demos/catwalk, agents, factory, and kb.Closes #1206