#1260 Retire the dead lint deferrals and clear run-core and foreman - #1265
Merged
Conversation
Removes every deferred lint rule that reported no violations, along with `unicorn/prefer-simple-condition-first`, which the shared preset already disables. lifecycle no longer carries a deferred-rule list or a package strict-lint config; agents and kb keep theirs, three warnings lighter each.
Clears run-core's remaining lint warnings. The package no longer carries a deferred-rule list or a package strict-lint config, so every rule the deferral held at `warn` now fails a strict-lint check.
Clears foreman's remaining lint warnings. The package no longer carries a deferred-rule list or a package strict-lint config, so every rule the deferral held at `warn` now fails a strict-lint check.
Dependency auditProduction dependency audit passed. |
williamthorsen
marked this pull request as ready for review
August 10, 2026 03:25
williamthorsen
added a commit
that referenced
this pull request
Aug 13, 2026
…e-v0.3.0 codeassembly-v0.9.0 factory-v0.2.6 codeassembly-mcp-v0.2.5 codeassembly-v0.9.0 - #1288 feat: State mutability and name the lede reader at the artifact type lists (#1303) - #1285 fix: Require plain bullets for checklists on both update-jira-ticket paths (#1302) - deps: Upgrade all deps to latest version - #1290 tooling: Upgrade eslint-config-typescript to 10 and complete manifest metadata (#1301) - #1294 feat: Specify artifact mutability and its sanctioned exceptions (#1297) - #1293 fix: Present and classify discretionary findings as actionable (#1295) - #1289 tooling: Remove shelled nmr calls from package manifests (#1291) - #1280 feat: Add a refresh path that edits an existing AGENTS.md instead of redrafting it (#1287) - #1055 feat: Replace the lede doctrine with corpus-derived guidance and retire the changelog-writer (#1286) - deps: Upgrade all deps to latest version - #1264 refactor: Consolidate error-message extraction on toolbelt.errors' describeError (#1284) - #1263 refactor: Retire the deferred-lint mechanism and adopt toolbelt.errors in agents (#1279) - #1262 refactor: Hoist unreadable for-of expressions and promote the lint rule to an error (#1276) - #1267 fix: Extend the no-hard-wrapping instruction to every GitHub composer (#1275) - #1177 fix: Rewrite links, tokens, and template variables in a Markdown file support entry (#1273) - #1176 feat: Add a ticketing-preferences hook to the skills that split and create tickets (#1268) - #1252 fix: Keep a skill's own sections out of injected guidance (#1266) - #1260 refactor: Fix lint and retire rule deferrals (#1265) - #1247 feat: Add a personal tooling-preferences rulebook (#1257) - #1251 feat: Let a rulebook declare that a guidance hook is how it is reached (#1259) - #1246 feat: Guard home-domain writes and record their provenance (#1254) - #1175 feat: Link new tickets to their blockers and parents (#1249) factory-v0.2.6 - deps: Upgrade all deps to latest version - #1290 tooling: Upgrade eslint-config-typescript to 10 and complete manifest metadata (#1301) - deps: Upgrade all deps to latest version - deps: Upgrade all deps to latest version - #1264 refactor: Consolidate error-message extraction on toolbelt.errors' describeError (#1284) kb-v0.6.0 - deps: Upgrade all deps to latest version - #1290 tooling: Upgrade eslint-config-typescript to 10 and complete manifest metadata (#1301) - #1289 tooling: Remove shelled nmr calls from package manifests (#1291) - #1264 refactor: Consolidate error-message extraction on toolbelt.errors' describeError (#1284) - #1261 feat: Attach causes to kb's loader errors and retire its lint deferral (#1272) - #1260 refactor: Fix lint and retire rule deferrals (#1265) codeassembly-lifecycle-v0.4.0 - #1290 tooling: Upgrade eslint-config-typescript to 10 and complete manifest metadata (#1301) - #1289 tooling: Remove shelled nmr calls from package manifests (#1291) - #1261 feat: Attach causes to kb's loader errors and retire its lint deferral (#1272) - #1260 refactor: Fix lint and retire rule deferrals (#1265) codeassembly-mcp-v0.2.5 - deps: Upgrade all deps to latest version - #1290 tooling: Upgrade eslint-config-typescript to 10 and complete manifest metadata (#1301) - #1289 tooling: Remove shelled nmr calls from package manifests (#1291) - #1264 refactor: Consolidate error-message extraction on toolbelt.errors' describeError (#1284) codeassembly-run-core-v0.3.0 - deps: Upgrade all deps to latest version - #1290 tooling: Upgrade eslint-config-typescript to 10 and complete manifest metadata (#1301) - #1289 tooling: Remove shelled nmr calls from package manifests (#1291) - #1264 refactor: Consolidate error-message extraction on toolbelt.errors' describeError (#1284) - #1261 feat: Attach causes to kb's loader errors and retire its lint deferral (#1272) - #1260 refactor: Fix lint and retire rule deferrals (#1265)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes deferred lint violations in the
lifecycle,run-core, andforemanpackages and removes the cap on the severity of associated rules when a strict-lint check is run.Why
A deferred rule sits at
warn, and the lint check runs with no--max-warnings, so it gates nothing: fresh violations accumulate unnoticed and the list stops meaning anything. Fourteen entries across the per-package lists had stopped naming a violation at all, and one of them was reviving a rule the shared config had already turned off, manufacturing seven warnings out of nothing.Details
♻️ Refactoring
.catch()rejection captures in run-core'srun-data-parser.unit.test.tsroute through a file-localcaptureRejectionhelper.errorstaysunknown, so every downstreaminstanceofnarrowing and property assertion is untouched; the helper's trailing throw names an unexpected resolution that previously surfaced as a confusingtoBeInstanceOfmismatch.run-directory-scanner's two discovery branches collapse to a ternary with a singleentries.pushtail, andticketsDirbecomeshasTicketsDir— it held a boolean but read as a path.vitest.setup.tsinstalls itsmatchMediaandResizeObserverstubs throughObject.defineProperties, each from atypeof globalThis.x-annotatedconstthat preserves the type checking the bare assignment had.vi.stubGlobal, the obvious substitute, would have been stripped by thevi.unstubAllGlobals()that two foreman suites run inafterEach, leaving Mantine to render withoutmatchMedia.FakeEventSource.dispatchbinds its listener list above the loop, and the manual resolver extraction inuseFleetSnapshot.unit.test.tsbecomesPromise.withResolvers.⚙️ Tooling
.config/eslint/deferred-lint-rules.ts, the{ files, rules }block ineslint.config.ts, and.config/strict-lint.config.ts. The repo root'sadvisoryRuleSeveritiesceiling governs them by cascade, whichstrict-lint --debugconfirms for every directory in each package.unicorn/prefer-simple-condition-firstleaves every list. It isoffin eslint-config-typescript 8.7.0, so an entry holding it atwarnwas re-enabling it.*malformed*fixture-ignore patterns leave lifecycle's and run-core'sglobalIgnores; neither package holds such a fixture.Closes #1260