#1263 Retire the deferred-lint mechanism and adopt toolbelt.errors in agents - #1279
Merged
Conversation
An error the CLI raises while wrapping a caught failure now carries that failure as its cause, so a stack trace reaches the original error rather than stopping at the diagnostic that replaced it. Wrapped messages join the underlying failure with a colon, replacing the em-dash two of them used.
…eError An `Error` carrying no message now reports as its class name rather than as an empty string, so a diagnostic built from one names something. The bin wrapper keeps its own copy: its top-level imports must stay resolvable without an install, so it can still report a missing build.
… variables Installing content for a harness whose home directory or identifier contains `$&`, ``$` ``, `$'`, or `$1` now writes that value verbatim. Those sequences were previously read as replacement patterns and expanded into the template variable they were replacing.
agents has no remaining violation of the ten rules its lint deferral held at warning level.
No package holds a lint deferral, so every rule the shared preset sets to error now fails a gate rather than passing as a warning. A repo-root test fails when a package reintroduces one, either as a rule list or as a strict-lint promotion cap.
Every relative import in agents and the root scripts names the `.ts` file it resolves to, rather than the `.js` file the build emits from it.
The KB config-health warning builds its detail through the shared describer, so an `Error` with an empty message names its class there as it does everywhere else in agents.
`replaceAll` with a string search value expands `$$`, `$&`, ``$` ``, and `$'`, and inserts `$1` verbatim because a string search captures nothing. The template-variable expander's note now names that set, and its test carries `$$` alongside `$&` and `$'`.
The guard sits at `.config/__tests__/`, beside `strict-lint.config.ts` and the other tool configs, rather than under a `.config/eslint/` directory that holds no configuration.
Dependency auditProduction dependency audit passed. |
williamthorsen
marked this pull request as ready for review
August 10, 2026 16:36
williamthorsen
added a commit
that referenced
this pull request
Aug 13, 2026
…e-v0.3.0 codeassembly-v0.9.0 factory-v0.2.6 codeassembly-mcp-v0.2.5 codeassembly-v0.9.0 - #1288 feat: State mutability and name the lede reader at the artifact type lists (#1303) - #1285 fix: Require plain bullets for checklists on both update-jira-ticket paths (#1302) - deps: Upgrade all deps to latest version - #1290 tooling: Upgrade eslint-config-typescript to 10 and complete manifest metadata (#1301) - #1294 feat: Specify artifact mutability and its sanctioned exceptions (#1297) - #1293 fix: Present and classify discretionary findings as actionable (#1295) - #1289 tooling: Remove shelled nmr calls from package manifests (#1291) - #1280 feat: Add a refresh path that edits an existing AGENTS.md instead of redrafting it (#1287) - #1055 feat: Replace the lede doctrine with corpus-derived guidance and retire the changelog-writer (#1286) - deps: Upgrade all deps to latest version - #1264 refactor: Consolidate error-message extraction on toolbelt.errors' describeError (#1284) - #1263 refactor: Retire the deferred-lint mechanism and adopt toolbelt.errors in agents (#1279) - #1262 refactor: Hoist unreadable for-of expressions and promote the lint rule to an error (#1276) - #1267 fix: Extend the no-hard-wrapping instruction to every GitHub composer (#1275) - #1177 fix: Rewrite links, tokens, and template variables in a Markdown file support entry (#1273) - #1176 feat: Add a ticketing-preferences hook to the skills that split and create tickets (#1268) - #1252 fix: Keep a skill's own sections out of injected guidance (#1266) - #1260 refactor: Fix lint and retire rule deferrals (#1265) - #1247 feat: Add a personal tooling-preferences rulebook (#1257) - #1251 feat: Let a rulebook declare that a guidance hook is how it is reached (#1259) - #1246 feat: Guard home-domain writes and record their provenance (#1254) - #1175 feat: Link new tickets to their blockers and parents (#1249) factory-v0.2.6 - deps: Upgrade all deps to latest version - #1290 tooling: Upgrade eslint-config-typescript to 10 and complete manifest metadata (#1301) - deps: Upgrade all deps to latest version - deps: Upgrade all deps to latest version - #1264 refactor: Consolidate error-message extraction on toolbelt.errors' describeError (#1284) kb-v0.6.0 - deps: Upgrade all deps to latest version - #1290 tooling: Upgrade eslint-config-typescript to 10 and complete manifest metadata (#1301) - #1289 tooling: Remove shelled nmr calls from package manifests (#1291) - #1264 refactor: Consolidate error-message extraction on toolbelt.errors' describeError (#1284) - #1261 feat: Attach causes to kb's loader errors and retire its lint deferral (#1272) - #1260 refactor: Fix lint and retire rule deferrals (#1265) codeassembly-lifecycle-v0.4.0 - #1290 tooling: Upgrade eslint-config-typescript to 10 and complete manifest metadata (#1301) - #1289 tooling: Remove shelled nmr calls from package manifests (#1291) - #1261 feat: Attach causes to kb's loader errors and retire its lint deferral (#1272) - #1260 refactor: Fix lint and retire rule deferrals (#1265) codeassembly-mcp-v0.2.5 - deps: Upgrade all deps to latest version - #1290 tooling: Upgrade eslint-config-typescript to 10 and complete manifest metadata (#1301) - #1289 tooling: Remove shelled nmr calls from package manifests (#1291) - #1264 refactor: Consolidate error-message extraction on toolbelt.errors' describeError (#1284) codeassembly-run-core-v0.3.0 - deps: Upgrade all deps to latest version - #1290 tooling: Upgrade eslint-config-typescript to 10 and complete manifest metadata (#1301) - #1289 tooling: Remove shelled nmr calls from package manifests (#1291) - #1264 refactor: Consolidate error-message extraction on toolbelt.errors' describeError (#1284) - #1261 feat: Attach causes to kb's loader errors and retire its lint deferral (#1272) - #1260 refactor: Fix lint and retire rule deferrals (#1265)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes all outstanding lint issues and removes the cap that downgraded the severity of associated rules during strict-lint runs. Error reporting in the
agentspackage is improved to include the underlying cause. Directory and file names with special dollar-sign sequences are now handled safely during deployment.Why
Ten rules sat at
warnin agents, where they blocked no gate and went unfixed long enough that one of them had been flagging a live defect the whole time. agents held the repository's last deferral, so clearing it is the difference between a mechanism sitting there for the next package to reach for and no mechanism at all. Errors thrown across the package discarded the failures they wrapped, leaving diagnostics that named a symptom without its cause.Details
🎉 Features
cause. Nine compose throughchainError; two that deliberately discard the caught message take a barecause, andassertFilledAnchorsResolvekeeps its own composition, which places the cause on its own line after a multi-clause explanation.🐛 Bug fixes
rewriteTemplateVariablespasses replacer functions toreplaceAll, so a harness home directory or identifier containing$$,$&,$`, or$'is inserted literally instead of expanding against the match it was meant to replace.♻️ Refactoring
describeErrorfrom@williamthorsen/toolbelt.errors/candidatereplaces the inlineerror instanceof Error ? error.message : String(error)at every site in agents, and the two locally defined copies incontent-validation.tsandguidance-hooks.tsare gone.bin/codeassembly.jskeeps its inline form so its top-level imports stay resolvable without an install, which is what lets it report a missing build.unicornrules are cleared with no rule suppressed inline. The threeno-incorrect-template-string-interpolationreports were false positives over CodeAssembly's own{token}syntax, so each site moves the token out of the template literal rather than silencing the rule..catch(() => {})cleanups inkb-edit/commit-supersede.tscollapse into anunlinkQuietlyhelper that carries the rationale for swallowing once instead of five times.packages/agents/.config/is deleted, along with theeslint.config.tsrule block and thetsconfig.jsoninclude that reached it. The root's advisory ceilings apply by cascade..jsimport specifiers in.tssource are rewritten to.ts, across agents and the rootscripts/suite.🧪 Tests
packages/*and fails when one declares a deferred-rule list or setsmaxSeverityin its ownstrict-lint.config.ts. It checks both halves because either alone restores the mechanism, and it covers a package added later without anyone remembering to add it.causegains an assertion on it:path-rewriter,branch-helpers,read-preferences,recall, andrulebook-deploy.$&,$$, and$'through both substitution parameters, so a revert to string replacement fails on either.📦 Dependencies
@williamthorsen/toolbelt.errors0.2.0, the same adoption kb made for its own loader errors.Closes #1263