Skip to content

#994 Remove the visualization hooks that logged an error on every prompt #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williamthorsen merged 2 commits into from
Jul 15, 2026
Merged

#994 Remove the visualization hooks that logged an error on every prompt #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c3af56
root|fix: Remove visualization hooks that logged an error each prompt
williamthorsen Jul 15, 2026
719b424
agents|docs: Re-anchor breadcrumb rationale to frontmatter resolution
williamthorsen Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .claude/hooks/on-input-received.sh
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions .claude/hooks/on-waiting-for-input.sh
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions .claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,5 @@
"command": "node",
"args": ["packages/mcp/dist/esm/cli.js"]
}
},
"hooks": {
"Notification": [
{
"matcher": "idle_prompt|permission_prompt|elicitation_dialog",
"hooks": [
{
"type": "command",
"command": ".claude/hooks/on-waiting-for-input.sh"
}
]
}
],
"UserPromptSubmit": [
{
"hooks": [
{
"type": "command",
"command": ".claude/hooks/on-input-received.sh"
}
]
}
]
}
}
4 changes: 2 additions & 2 deletions packages/agents/content/skills/orchestrate/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,13 +229,13 @@ Prefix the status line with a colored emoji for visual distinction:

The `init_run` tool creates the run directory, writes a v3 `run-index.json` header, creates an empty `run-log.jsonl`, and emits a `run_started` event automatically. Do not write `run-index.json` manually.

**Write breadcrumb** (MCP success path only): After a successful `init_run`, write the active run directory to a breadcrumb file so that Claude Code hooks can discover it:
**Write breadcrumb** (MCP success path only): After a successful `init_run`, write the active run directory to a breadcrumb file so that `resolve-frontmatter.sh` can resolve the active run's `run_id` when stamping artifact frontmatter:

```
mkdir -p .claude/tmp && echo "{run-dir}" > .claude/tmp/active-run-dir
```

Only write the breadcrumb after a successful `init_run` (MCP available). Do not write it on the MCP-unavailable fallback path. When MCP is unavailable, no `run-log.jsonl` is created, so the hooks have nothing to append to.
Only write the breadcrumb after a successful `init_run` (MCP available). Do not write it on the MCP-unavailable fallback path, where no run directory is created and there is no `run_id` to resolve.

**Failure — MCP unavailable** (tool not found / server not connected): Resolve `mcp_policy` (see "Resolving MCP policy" above) and apply the policy:
- `required`: Abort with a clear message explaining that MCP is unavailable and the policy requires it.
Expand Down
Loading