[v2] fix bridge reload issue#1836
Closed
joonhocho wants to merge 2 commits into
Closed
Conversation
|
I really don't think this is good enough, that's why I made a comment instead of a pull request. If this is to be merged in it should probably note the hack in a comment so someone can take a look in the future. |
Author
|
@rustybox I agree. Added TODO comment. I still think it's 10x better than nothing since you can't reload without this. |
|
It works for me too. |
brunolemos
approved these changes
Dec 13, 2017
brunolemos
left a comment
brunolemos
left a comment
There was a problem hiding this comment.
Awesome! Worked for me.
"react-native": "^0.51.0",
"react-native-gesture-handler": "^1.0.0-alpha.35",
Merged
|
hi, how do we follow which release commits get into? Are these fixes in 1.1.x versions or only 2.x versions? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1514
There could be better solution than this, but I think it's good enough for now.