Support iOS 11 prefersLargeTitles #1643 by yomybaby · Pull Request #2090 · wix/react-native-navigation

yomybaby · 2017-10-28T09:04:50Z

Please, see #1643

eliperkins

Nice!

eliperkins · 2017-11-03T20:50:24Z

+    NSNumber *prefersLargeTitles = self.navigatorStyle[@"prefersLargeTitles"];
+    BOOL prefersLargeTitlesBool = prefersLargeTitles ? [prefersLargeTitles boolValue] : NO;
+    if (prefersLargeTitlesBool) {
+      [self.navigationController.navigationBar setPrefersLargeTitles:YES];


These setters can be written as self.navigationController.navigationBar.prefersLargeTitles = prefersLargeTitlesBool as well, to use Objective-C 2.0 syntax, as well as reuse the prefersLargeTitlesBool variable to match/simplify the logic.

eliperkins · 2017-11-03T21:31:39Z

    }
  }
+
+  if ([[[UIDevice currentDevice] systemVersion] floatValue] >= 11.0) {


What do you think about using a if (@available(iOS 11.0, *)) check here instead of checking the device's system version?

Since the @available can only be used in xcode9 and higher (backward compatible wise), it's better to use device's system version

If the argument is for backwards compatibility, I would argue that using [self.navigationController.navigationBar respondsToSelector:@selector(setPrefersLargeTitles:)] would be a better alternative than a version check.

eliperkins · 2017-11-09T21:07:32Z

What can I do to help get this PR merged in?

gran33 · 2017-11-12T20:25:55Z

@eliperkins can u plz fix it to
[self.navigationController.navigationBar respondsToSelector:@selector(setPrefersLargeTitles:)]
?

eliperkins · 2017-11-14T00:13:11Z

@gran33 Since I'm just a contributor and not a collaborator, I can't make edits to this PR.

@yomybaby can you make that change?

Otherwise, I'll need to open a different PR or we can merge this and fix it in master.

yomybaby · 2017-11-14T06:16:55Z

Sorry for late reply. I’ll do that tonight. 🙏 2017년 11월 14일 (화) 오전 8:13, Eli Perkins <notifications@github.com>님이 작성:

…

@gran33 <https://github.com/gran33> Since I'm just a contributor and not a collaborator, I can't make edits to this PR. @yomybaby <https://github.com/yomybaby> can you make that change? Otherwise, I'll need to open a different PR or we can merge this and fix it in master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2090 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAl6n1NH35ncCcShi9nb5K9AH-RTfyi3ks5s2NspgaJpZM4QJ37j> .

yomybaby · 2017-11-14T16:20:43Z

@eliperkins I just changed some code. Thank for your suggestion.

birkir · 2017-11-17T06:23:28Z

The ScrollView behaviour is a little weird.
The complete animation happens on like 5 pixel scroll.

Works fine if the scrollview content has less height than the scrollview itself.

Works vs Does not

eliperkins · 2017-11-17T15:53:13Z

@birkir I don't think this is an issue with this library, but rather just an iOS quirk.

If you find the root cause of this is in react-native-navigation, I would encourage you to open a separate issue.

birkir · 2017-11-17T16:21:06Z

Yeah I'm more suspecting React Native in general.

Maybe this recently added method can be used to fix the problem

icodesign · 2017-11-20T09:51:26Z

@yoavaa @eliperkins Should we get it merged?

This reverts commit 9f2f15b.

birkir · 2017-11-21T17:07:50Z

What happened? @gran33

gran33 · 2017-11-21T17:16:54Z

Sorry guys, This PR breaks xcode8 users, and force xcode8 to update to xcode9.

eliperkins · 2017-11-21T17:21:00Z

Can we open a discussion to updating this library to require Xcode 9? It seems like quite a big deal to cut features of the most recent operating system in order to support an outdated toolchain.

brunolemos · 2017-11-21T17:27:28Z

Xcode 9 is the latest stable version, that's what we should support.
Also, people can have multiple versions of Xcode on their machine.

gran33 · 2017-11-22T08:11:44Z

@yomybaby can u plz try to build it in xcode8 and add

#ifdef __IPHONE_11_0

YOUR_CODE_HERE

#endif

birkir · 2017-11-22T15:28:52Z

About the scroll issue... I think you may be right about it being a iOS quirk. I saw one app that has the same bug Parcel (I don't know if it's an react native app or not).

But somehow Apple makes it look smooth in their apps, I deeply want to fix the problem, so any ideas are greatly appreciated, I don't know where to look or start debugging.

dkast · 2017-11-25T15:47:23Z

Any updates on this issue?

guyca · 2017-11-26T07:13:49Z

@yomybaby Sorry to trouble you, could you resubmit the PR with support for xcode 8?

brunolemos · 2017-11-26T07:42:46Z

@guyca I think if you git cherry-pick his commit add add the xcode 8 support would be enough, if he is not available

* master: (22 commits) setTabButton to change the label of the TabButton (wix#2215) 3D Touch Preview API (wix#2186) Update android-specific-use-cases.md Update android-specific-use-cases.md Load props from props registry for redux screens Nav bar save props (wix#2211) Support passing unserializable props to custom navBar component Save buttons props for root screens Ensure that styles set on individual buttons are not overridden (wix#2200) Update top-level-api.md (Android) Allow disableOpenGesture right or left in the drawer (wix#2189) Revert "Support iOS 11 prefersLargeTitles #1643 (wix#2090)" (wix#2204) Support iOS 11 prefersLargeTitles #1643 (wix#2090) Support passing unserializable props to custom button (wix#2192) addOnNavigatorEvent improvements (wix#2175) Fix missing props (wix#2179) Revert "Don't custom button props over the bridge (wix#2174)" (wix#2177) Don't custom button props over the bridge (wix#2174) Set missing TopBar background color Register multiple navigatorEventListeners (wix#2173) ...

anonrig · 2017-11-28T16:13:04Z

It seems that this PR is reverted in master, any ETA on the status? I couldn't keep track.

brunolemos · 2017-12-13T20:59:42Z

Does anyone know where can I add this code on v2?

--
I'm using patch-package and picking some much needed PRs like #1836 and #1816.

* Support iOS 11 prefersLargeTitles #1643 * better and more simple version checking and setting

This reverts commit 9f2f15b.

* Support iOS 11 prefersLargeTitles #1643 * better and more simple version checking and setting

This reverts commit 9f2f15b.

doertli · 2018-01-25T01:08:49Z

Is this PR likely to get remerged anytime soon?

gran33 · 2018-01-26T20:18:26Z

Yes, will update.
cc: @yogevbd @guyca

brunolemos · 2018-01-26T20:59:29Z

It was already remerged yesterday on #2593 AFAIK.

Support iOS 11 prefersLargeTitles #1643

ef19b8e

guyca assigned gran33 Oct 29, 2017

eliperkins approved these changes Nov 3, 2017

View reviewed changes

eliperkins reviewed Nov 3, 2017

View reviewed changes

eliperkins mentioned this pull request Nov 3, 2017

[iOS] Large title text attributes #2112

Merged

better and more simple version checking and setting

4db2d61

yomybaby force-pushed the prefersLargeTitles branch from a2399ee to 4db2d61 Compare November 14, 2017 16:18

Merge branch 'master' into prefersLargeTitles

a3af58c

gran33 merged commit 9f2f15b into wix:master Nov 20, 2017

gran33 added a commit that referenced this pull request Nov 21, 2017

Revert "Support iOS 11 prefersLargeTitles #1643 (#2090)"

7f482eb

This reverts commit 9f2f15b.

gran33 mentioned this pull request Nov 21, 2017

Revert "Support iOS 11 prefersLargeTitles #1643" #2204

Merged

gran33 added a commit that referenced this pull request Nov 21, 2017

Revert "Support iOS 11 prefersLargeTitles #1643 (#2090)" (#2204)

e8333ce

This reverts commit 9f2f15b.

garrettm pushed a commit to Ginger-Labs/react-native-navigation that referenced this pull request Dec 19, 2017

Support iOS 11 prefersLargeTitles #1643 (wix#2090)

85fb72f

* Support iOS 11 prefersLargeTitles #1643 * better and more simple version checking and setting

garrettm pushed a commit to Ginger-Labs/react-native-navigation that referenced this pull request Dec 19, 2017

Revert "Support iOS 11 prefersLargeTitles #1643 (wix#2090)" (wix#2204)

b81376f

This reverts commit 9f2f15b.

garrettm pushed a commit to Ginger-Labs/react-native-navigation that referenced this pull request Dec 19, 2017

Support iOS 11 prefersLargeTitles #1643 (wix#2090)

d72bef2

* Support iOS 11 prefersLargeTitles #1643 * better and more simple version checking and setting

garrettm pushed a commit to Ginger-Labs/react-native-navigation that referenced this pull request Dec 19, 2017

Revert "Support iOS 11 prefersLargeTitles #1643 (wix#2090)" (wix#2204)

934951d

This reverts commit 9f2f15b.

Conversation

yomybaby commented Oct 28, 2017

Uh oh!

eliperkins left a comment

Choose a reason for hiding this comment

Uh oh!

eliperkins Nov 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eliperkins Nov 3, 2017

Choose a reason for hiding this comment

Uh oh!

gran33 Nov 3, 2017

Choose a reason for hiding this comment

Uh oh!

eliperkins Nov 3, 2017

Choose a reason for hiding this comment

Uh oh!

eliperkins commented Nov 9, 2017

Uh oh!

gran33 commented Nov 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eliperkins commented Nov 14, 2017

Uh oh!

yomybaby commented Nov 14, 2017 via email

Uh oh!

yomybaby commented Nov 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

birkir commented Nov 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eliperkins commented Nov 17, 2017

Uh oh!

birkir commented Nov 17, 2017

Uh oh!

icodesign commented Nov 20, 2017

Uh oh!

birkir commented Nov 21, 2017

Uh oh!

gran33 commented Nov 21, 2017

Uh oh!

eliperkins commented Nov 21, 2017

Uh oh!

brunolemos commented Nov 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gran33 commented Nov 22, 2017

Uh oh!

birkir commented Nov 22, 2017

Uh oh!

dkast commented Nov 25, 2017

Uh oh!

guyca commented Nov 26, 2017

Uh oh!

brunolemos commented Nov 26, 2017

Uh oh!

anonrig commented Nov 28, 2017

Uh oh!

brunolemos commented Dec 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doertli commented Jan 25, 2018

Uh oh!

gran33 commented Jan 26, 2018

Uh oh!

brunolemos commented Jan 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

eliperkins Nov 3, 2017 •

edited

Loading

gran33 commented Nov 12, 2017 •

edited

Loading

yomybaby commented Nov 14, 2017 •

edited

Loading

birkir commented Nov 17, 2017 •

edited

Loading

brunolemos commented Nov 21, 2017 •

edited

Loading

brunolemos commented Dec 13, 2017 •

edited

Loading