propose cleaner, more familiar usage patterns#2
Closed
aarongreenwald wants to merge 1 commit into
Closed
Conversation
Contributor
|
Unrelated to this PR, I added full redux support. When doing so, I had to change the API slightly to handle redux connected components easily. I updated example according to the new API style, let me know if this change achieves the same purpose as your suggestion: https://github.com/wix/react-native-navigation/blob/master/example |
Contributor
Author
|
@talkol I like what you did in the two examples, I think they are both much better and achieve the same results plus more, so I'm closing this. Thanks! |
jstheoriginal
pushed a commit
to jstheoriginal/react-native-navigation
that referenced
this pull request
Jul 17, 2017
…-support Added requiresFullScreen param to LightBox.
legildas
pushed a commit
to crazybaud/react-native-navigation
that referenced
this pull request
Mar 7, 2018
yogevbd
pushed a commit
that referenced
this pull request
May 2, 2018
* feat: support a “modal” prop for tabbed ios apps * fix: apply temp fix for react-native-navigation#1502 (#1) * fix: enable fab icon scaling (#2) * v1.1.340 [ci skip] * Update FloatingActionButtonCoordinator.java * Update top-level-api.md * Update package.json
This was referenced May 30, 2018
reimertz
pushed a commit
to mavencook/react-native-navigation
that referenced
this pull request
Sep 14, 2018
* feat: support a “modal” prop for tabbed ios apps * fix: apply temp fix for react-native-navigation#1502 (#1) * fix: enable fab icon scaling (wix#2) * v1.1.340 [ci skip] * Update FloatingActionButtonCoordinator.java * Update top-level-api.md * Update package.json
shalehaha
pushed a commit
to shalehaha/react-native-navigation
that referenced
this pull request
Dec 15, 2018
merge new version
JustinKasad
pushed a commit
to JustinKasad/react-native-navigation
that referenced
this pull request
Mar 27, 2019
added try/catch to avoid app crashing during multi screen load
alpamys-qanybet
added a commit
to alpamys-qanybet/react-native-navigation
that referenced
this pull request
Oct 16, 2019
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the example app to encourage/propose a usage pattern that is more familiar to React Native developers, feels less invasive, and better highlights some of the power of this solution by showing how it can be used to create a clean separation of concerns between multiple modules in the same application.
Component. A developer working on a project using react-native-navigation should feel at home immediately and adoption shouldn't feel like a lot of change. The README doesn't seem very scary, but looking at the example made me kind of wrinkle my nose a bit. :)Screeninstead ofComponent. I'm considering ways around this, but I'm not sure it's a good idea so we'll come back to this. If we come up with a way to use this solution declaratively we'll probably be able to get rid of theScreenbusiness along with all uses ofthis.navigator.Screenif you want to reference the navigator inside the screen. You can push any component if it's registered, regardless of type. I'm not sure how often people have screens that don't do any navigation, but I suppose it could happen. I think clarifying this reduces the amount of mysterious magic going on.I might be missing something in the implementation that makes my proposal back recommendation. If this isn't feasible or if you think it's not a good idea, let me know.