Support a “modal” prop for tabbed iOS apps#1578
Conversation
|
+1, can we get this merged? |
# Conflicts: # ios/RCCTabBarController.m
# Conflicts: # android/app/src/main/java/com/reactnativenavigation/views/LightBox.java
|
@kevboh Thank you so much for this! I merged your pull into my Fork and it's working like a dream! Hope your pull gets merged soon. |
v1.1.340 [ci skip]
…navigation into feat-add-modal-tabs
|
@guyca Any update on the merge for this, please? |
There was a problem hiding this comment.
I'd like to see this as well. Thanks for the work & hopefully it gets merged.
The naming here doesn't really make all that much sense to me, though. The button isn't triggering a modal, it's instead simply never activating the screen. It's a nice building block for more than just modals, so I think it'd be far more clear to rename it to something other than modal, i.e. nonActivating.
Also, is there a reason that this shouldn't be implemented for Android as well?
| navigatorStyle: {}, // override the navigator style for the tab screen, see "Styling the navigator" below (optional), | ||
| navigatorButtons: {} // override the nav buttons for the tab screen, see "Adding buttons to the navigator" below (optional) | ||
| navigatorButtons: {}, // override the nav buttons for the tab screen, see "Adding buttons to the navigator" below (optional) | ||
| modal: false // prevent tab selection and send a 'modalTabSelected' navigator event instead (optional) |
There was a problem hiding this comment.
This should contain iOS only for clarity.
|
@guyca Any update on this, please?? |
|
Can this be done in RNN V2? |
* r_master: (31 commits) Fix syntax error: "screen" is read-only (wix#3237) Revert "- Fixes freeze of passProps on iOS (wix#3220)" (wix#3222) - Fixes freeze of passProps on iOS (wix#3220) allows you to show a lightbox directly after dismissing on ios (wix#1466) Enable RTL support on LeftButton (wix#3154) Trigger build Prevent navBar header background transition in modals, fixes black background in modals navBar Link to root of movieapp repo (wix#3112) Test [skip ci] Revert "Support a “modal” prop for tabbed iOS apps (wix#1578)" Revert "fix build issue" fix build issue fixed a bug modal viewController was not deallocated when to call dismissAllModals (wix#2843) Support a “modal” prop for tabbed iOS apps (wix#1578) Add iPad landscape launch image (wix#2473) Now passing an activity to clearHostOnActivityDestroy (wix#3133) Change CI var env to JENKINS_CI Avoid NPR in SET (wix#3115) Update README.md Update README.md ...
|
Is there an example usage anywhere? |
|
Was this reverted? |
* feat: support a “modal” prop for tabbed ios apps * fix: apply temp fix for react-native-navigation#1502 (#1) * fix: enable fab icon scaling (wix#2) * v1.1.340 [ci skip] * Update FloatingActionButtonCoordinator.java * Update top-level-api.md * Update package.json
This reverts commit 5cd2972.
|
Hello, is there a way this will be merged and will work on android too? |
11 participants
This adds support for a
modalboolean prop when starting a tab-based app on iOS. If set totrue, tapping that tab will not select it and instead emit a"modalTabSelected"event navigation event, which can be listened to in order to present a modal on tab tap (or do anything else, I suppose).If there's a better/accepted way to do this already, please let me know and close this PR. Thanks.