Skip to content

[iOS] Large title text attributes#2112

Merged
yogevbd merged 4 commits into
wix:masterfrom
eliperkins:largeTitleTextAttributes
Jan 28, 2018
Merged

[iOS] Large title text attributes#2112
yogevbd merged 4 commits into
wix:masterfrom
eliperkins:largeTitleTextAttributes

Conversation

@eliperkins
Copy link
Copy Markdown
Contributor

This adds support for changing largeTitleTextAttributes on navigation controllers, including custom font sizes, font families, etc.

See Apple docs here: https://developer.apple.com/documentation/uikit/uinavigationbar/2919946-largetitletextattributes

Supports #2090

Related to #1643

@anonrig
Copy link
Copy Markdown

anonrig commented Nov 28, 2017

What's the ETA on this PR? 👍

@brunolemos
Copy link
Copy Markdown

Needs rebase.

@eliperkins eliperkins force-pushed the largeTitleTextAttributes branch from 46191bd to 64b8967 Compare January 26, 2018 21:33
@eliperkins
Copy link
Copy Markdown
Contributor Author

@brunolemos done

@yogevbd yogevbd merged commit f7ec9ee into wix:master Jan 28, 2018
gran33 pushed a commit that referenced this pull request Jan 28, 2018
gran33 added a commit that referenced this pull request Jan 28, 2018
chilinh added a commit to chilinh/react-native-navigation that referenced this pull request Jan 29, 2018
* r_master:
  update gradle
  fixed android getLaunchArgs
  fix ios
  getInitialProps ios support (wix#2606)
  getLaunchArgs android
  Revert "[iOS] Large title text attributes (wix#2112)" (wix#2603)
  [iOS] Large title text attributes (wix#2112)
  xcode 8 crash fix
  Add support for prefersLargeTitles in iOS 11 (wix#2593)
@eliperkins eliperkins deleted the largeTitleTextAttributes branch January 29, 2018 16:13
@eladgel
Copy link
Copy Markdown

eladgel commented Apr 4, 2018

@eliperkins when pushing from right a screen that has in it's navigatorStyling
navBarTransparent: true

the new screen navbar bg is set like this
navBarBackgroundColor: 'red',

the background of the title element get's the color of the navbar according to the statusBarColor,
when you scroll the bg turns red
image

@sreuter
Copy link
Copy Markdown

sreuter commented Apr 10, 2018

Should this transform to a smaller title when scrolling up, like in the Mail example here https://github.com/wix/react-native-navigation/issues/1643#issue-248144154?

Update Pardon me, it actually does that already. Awesome sauce!

@DazChong
Copy link
Copy Markdown

DazChong commented Apr 11, 2018

I'm having screen bottom section of flickering if using largeTitle on iPhone X, the refreshControl and content jumped when pull-to-refresh, large title overlap refreshControl, and randomly scrolling to top stuck with no rubber-band effect and cannot pull-to-refresh.

Update:
All the above issue gone with this combination:

  • navigatorStyle: drawUnderNavBar: true
  • FlatList/ScrollView: contentInsetAdjustmentBehavior={'automatic'}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants