[iOS] Add support for bar button system items#2133
Merged
Conversation
Collaborator
|
Hey @eliperkins, is this pr compatible with xcode8? |
Contributor
Author
|
Yup. Nothing specific to Xcode 9 here, it should work fine in Xcode 8. |
|
Can you provide an example of how to access the bar button system item |
nbomberger
pushed a commit
to najabu/react-native-navigation
that referenced
this pull request
Nov 29, 2017
* Add converter for UIBarButtonSystemItem * Add support for UIBarButtonSystemItem-styled buttons * Add documentation about systemItem
thanhzusu
pushed a commit
to thanhzusu/react-native-navigation
that referenced
this pull request
Dec 7, 2017
* master: Revert "setStyle to style the according TabBar (wix#2224)" (wix#2276) setStyle to style the according TabBar (wix#2224) Fix dismissAllModal API - the root won't unregister when invoke dismissAllModals (wix#2255) Expose keyUp event from modals to ActivityCallback [iOS] Add support for bar button system items (wix#2133)
garrettm
pushed a commit
to Ginger-Labs/react-native-navigation
that referenced
this pull request
Dec 19, 2017
* Add converter for UIBarButtonSystemItem * Add support for UIBarButtonSystemItem-styled buttons * Add documentation about systemItem
garrettm
pushed a commit
to Ginger-Labs/react-native-navigation
that referenced
this pull request
Dec 19, 2017
* Add converter for UIBarButtonSystemItem * Add support for UIBarButtonSystemItem-styled buttons * Add documentation about systemItem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UIKit supplies a range of glyphs to be used in navigation bar buttons, so let's expose them to developers to make better native apps!
This adds support for the
systemItemkey-value in the button config to allow for placing this type ofUIBarButtonItems in the navigation bar.More information about these glyphs can be found in Apple's Human Interface Guidelines.