Skip to content

setStyle to style the according TabBar#2224

Merged
guyca merged 20 commits into
wix:masterfrom
postillonmedia:master
Dec 4, 2017
Merged

setStyle to style the according TabBar#2224
guyca merged 20 commits into
wix:masterfrom
postillonmedia:master

Conversation

@danielang
Copy link
Copy Markdown
Contributor

@danielang danielang commented Nov 25, 2017

Use navigator.setStyle({...} to set the style of TabBar of the according screen at runtime for iOS and Android.
Good for theming purpose.

Exampe:

this.props.navigator.setStyle({
        tabBarButtonColor: '#0d0d0d',
        tabBarSelectedButtonColor: '#ff6c33',
        tabBarBackgroundColor: '#ffffff',
        navigationBarColor: '#ffffff',
});

@danielang danielang mentioned this pull request Nov 25, 2017
Closed
guyca
guyca previously requested changes Nov 26, 2017
View reviewed changes
Comment thread android/app/src/main/java/com/reactnativenavigation/views/BottomTabs.java Outdated
}

private boolean hasBadgeTextColor(StyleParams params) {
return params.bottomTabBadgeTextColor != null &&
Copy link
Copy Markdown
Collaborator

@guyca guyca Nov 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can avoid adding these convince method by initializing these style properties so they are never null here. The Color class is meant to be used as a null object

Copy link
Copy Markdown
Contributor Author

@danielang danielang Nov 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of cause. This was original coding, so I've adapted it to match this code style.
Which color will be the default one?

Copy link
Copy Markdown
Collaborator

@guyca guyca Nov 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to specify a default color since in this case hasColor() will return false as expected.

Copy link
Copy Markdown
Contributor Author

@danielang danielang Nov 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you will only check hasColor() in the setStyle function and remove the has...functions?

Copy link
Copy Markdown
Collaborator

@guyca guyca Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly :)

@danielang
Copy link
Copy Markdown
Contributor Author

danielang commented Nov 27, 2017

any reaction? 😄

@guyca
Copy link
Copy Markdown
Collaborator

guyca commented Nov 27, 2017

@danielang Hey sorry about the delay. If I don't respond you can always try pinging me on discord. 👍

@guyca guyca dismissed their stale review December 4, 2017 10:11

dismissing

@guyca guyca merged commit 076ee73 into wix:master Dec 4, 2017
guyca added a commit that referenced this pull request Dec 5, 2017
@guyca
Revert "setStyle to style the according TabBar (#2224)"
efb3319 
This reverts commit 076ee73.
@guyca guyca mentioned this pull request Dec 5, 2017
Merged
guyca added a commit that referenced this pull request Dec 5, 2017
@guyca
Revert "setStyle to style the according TabBar (#2224)" (#2276)
2c9ba1d 
This reverts commit 076ee73.
thanhzusu pushed a commit to thanhzusu/react-native-navigation that referenced this pull request Dec 7, 2017
Merge branch 'master' into thanhzusu-patch-for-3km
eed2eb2 
* master:
  Revert "setStyle to style the according TabBar (wix#2224)" (wix#2276)
  setStyle to style the according TabBar (wix#2224)
  Fix dismissAllModal API - the root won't unregister when invoke dismissAllModals (wix#2255)
  Expose keyUp event from modals to ActivityCallback
  [iOS] Add support for bar button system items (wix#2133)
garrettm pushed a commit to Ginger-Labs/react-native-navigation that referenced this pull request Dec 19, 2017
@danielang @garrettm
setStyle to style the according TabBar (wix#2224)
c94aa6c 
setTabButton -> has now the property 'label' to change the label of the TabButton

iOS update style-update rutine to update each viewcontroller in a NavigationViewController
tabButtonColor improvement
garrettm pushed a commit to Ginger-Labs/react-native-navigation that referenced this pull request Dec 19, 2017
@guyca @garrettm
Revert "setStyle to style the according TabBar (wix#2224)" (wix#2276)
eda119e 
This reverts commit 076ee73.
garrettm pushed a commit to Ginger-Labs/react-native-navigation that referenced this pull request Dec 19, 2017
@danielang @garrettm
setStyle to style the according TabBar (wix#2224)
1352f9f 
setTabButton -> has now the property 'label' to change the label of the TabButton

iOS update style-update rutine to update each viewcontroller in a NavigationViewController
tabButtonColor improvement
garrettm pushed a commit to Ginger-Labs/react-native-navigation that referenced this pull request Dec 19, 2017
@guyca @garrettm
Revert "setStyle to style the according TabBar (wix#2224)" (wix#2276)
b1566a7 
This reverts commit 076ee73.
@danielang danielang mentioned this pull request Jan 15, 2018
Merged
@witalobenicio
Copy link
Copy Markdown

witalobenicio commented Aug 21, 2018

Is this working on latest release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guyca guyca guyca left review comments

Assignees

@gran33 gran33

@guyca guyca

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danielang @guyca @witalobenicio @gran33