Skip to content

V2 Current tab by container ID#2264

Merged
guyca merged 7 commits into
v2from
currentTabByContainerID
Dec 27, 2017
Merged

V2 Current tab by container ID#2264
guyca merged 7 commits into
v2from
currentTabByContainerID

Conversation

@yogevbd
Copy link
Copy Markdown
Collaborator

@yogevbd yogevbd commented Dec 3, 2017

No description provided.

@yogevbd yogevbd added the v2 label Dec 3, 2017
Copy link
Copy Markdown
Contributor

@DanielZlotin DanielZlotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add e2e tests

@guyca
Copy link
Copy Markdown
Collaborator

guyca commented Dec 20, 2017

@yogevbd What's the status of this PR?

@yogevbd yogevbd force-pushed the currentTabByContainerID branch from e68c9c4 to 2857af9 Compare December 25, 2017 14:49
@yogevbd yogevbd requested a review from DanielZlotin December 25, 2017 15:26
@yogevbd yogevbd requested a review from bogobogo December 26, 2017 14:27
const Navigation = require('react-native-navigation');
const testIDs = require('../testIDs');

let globalFirstContainerID;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed once we have broadcasting mechanism #2417

@guyca guyca merged commit 79daa62 into v2 Dec 27, 2017
@guyca guyca deleted the currentTabByContainerID branch December 27, 2017 07:24
chilinh added a commit to chilinh/react-native-navigation that referenced this pull request Jan 5, 2018
* r_v2: (34 commits)
  Fix typo in README.md
  top tabs support - ios (wix#2454)
  homogenous root view container protocol (wix#2455)
  Fixing stuff (wix#2456)
  Support changing TopTabs font size (wix#2449)
  Implement selected and unselected toTab color (wix#2429)
  added drawUnder (wix#2427)
  Fix failing android e2e (wix#2424)
  Load typface when parsing options (wix#2416)
  V2 Current tab by container ID (wix#2264)
  remove package.lock from npmignore
  V2 rn49 (wix#2411)
  Top tab font family (wix#2410)
  added missing options (wix#2408)
  V2 async commands (wix#2407)
  Tab bar items (wix#2345)
  Added Jenkinsfile
  Added new jenkins file for jenkins pipleine
  [docs] Linkify parameter types (wix#2403)
  [docs] Change heading depth (wix#2401)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants