Top tab font family#2410
Merged
Merged
Conversation
Cool04ek
previously requested changes
Dec 26, 2017
| if (json == null) return result; | ||
|
|
||
| result.title = json.optString("title", NO_VALUE); | ||
| result.fontFamily = typefaceManager.getTypeFace(json.optString("titleFontFamily")); |
Contributor
There was a problem hiding this comment.
Why do you need to load typeface now. I mean it's better to have it consistent. Because topBar options load typeface in presenter, and topTabs in parser.
guyca
dismissed
Cool04ek’s stale review
As agreed, will fix this in a separate pr.
chilinh
added a commit
to chilinh/react-native-navigation
that referenced
this pull request
Jan 5, 2018
* r_v2: (34 commits) Fix typo in README.md top tabs support - ios (wix#2454) homogenous root view container protocol (wix#2455) Fixing stuff (wix#2456) Support changing TopTabs font size (wix#2449) Implement selected and unselected toTab color (wix#2429) added drawUnder (wix#2427) Fix failing android e2e (wix#2424) Load typface when parsing options (wix#2416) V2 Current tab by container ID (wix#2264) remove package.lock from npmignore V2 rn49 (wix#2411) Top tab font family (wix#2410) added missing options (wix#2408) V2 async commands (wix#2407) Tab bar items (wix#2345) Added Jenkinsfile Added new jenkins file for jenkins pipleine [docs] Linkify parameter types (wix#2403) [docs] Change heading depth (wix#2401) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API