Adding preferredContentSize#2529
Merged
Merged
Conversation
Collaborator
|
Thanks for the pr @DavidCMurphy |
added 2 commits
January 16, 2018 11:29
…entationStyle properties
…native-navigation into preferredContentSize
Contributor
Author
|
Hey @guyca, this should work, let me know if i'm missing anything. |
chilinh
added a commit
to chilinh/react-native-navigation
that referenced
this pull request
Jan 22, 2018
* r_master: SetStyle fix (wix#2539) Update ISSUE_TEMPLATE fix(start app): show red screen in case an error is thrown while starting the app (wix#2556) Xcode 8 fixes fixed swizzle in xcode 8 Back-port insets fix to v1 Solved doc formatting issues (wix#2544) Update README.md (wix#2537) Update styling-the-navigator.md Adding preferredContentSize (wix#2529) Revert "setStyle to style the according TabBar (wix#2524)" setStyle to style the according TabBar (wix#2524)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So while building an iPad application using this navigation library i have come across the need to set the size on controllers presented through modalPresentationStyle = formSheet.
Though currently we don't have any prop that allows you to do so. Obviously this is iOS specific but i think some other people would like some flexibility in this regard.
example: