Skip to content

setStyle to style the according TabBar#2524

Merged
yogevbd merged 32 commits into
wix:masterfrom
postillonmedia:master
Jan 15, 2018
Merged

setStyle to style the according TabBar#2524
yogevbd merged 32 commits into
wix:masterfrom
postillonmedia:master

Conversation

@danielang
Copy link
Copy Markdown
Contributor

@danielang danielang commented Jan 15, 2018

fix bugs of PR #2224

  • Hidden TabBar appears after setStyle
  • CustomNavBar was overrideen after setStyle

Use navigator.setStyle({...} to set the style of TabBar of the according screen at runtime for iOS and Android.
Good for theming purpose.

Exampe:

this.props.navigator.setStyle({
        tabBarButtonColor: '#0d0d0d',
        tabBarSelectedButtonColor: '#ff6c33',
        tabBarBackgroundColor: '#ffffff',
        navigationBarColor: '#ffffff',
});

@danielang
setTabButton -> has now the property 'label' to change the label of t…
531526f 
…he TabButton
@danielang
Add to documentation
23ecde0
@danielang
Merge branch 'master' into master
539682e
@danielang
[BugFix] use i instead of 0 to check all TabItems
3c6c6f2
@danielang
Merge remote-tracking branch 'origin/master'
e1e82e3
@danielang
setStyle -> to change bottomTabBar
0cb6f74
@danielang
Merge pull request #1 from wix/master
36be329 
update fork
@danielang
update android
87b23dd
@danielang
Merge remote-tracking branch 'origin/master'
bc69fbe
@danielang
remove hass...-functions
038b040
@danielang
Merge branch 'master' into master
7ba5bdd
@danielang
update iOS set TabStyle
6bcaec0
@danielang
Merge remote-tracking branch 'origin/master'
3a61bab
@danielang
iOS change icon color on buttonTabColor has been changed
11df9b4
@danielang
iOS update style-update rutine to update each viewcontroller in a Nav…
c162157 
…igationViewController

tabButtonColor improvement
@danielang
iOS add forgotten header declaration
2914946
@danielang
Merge branch 'master' into master
f580555
@danielang
iOS fix c&p error
2976290
@danielang
Merge remote-tracking branch 'origin/master'
83875bc
@danielang
[Android] initialize colors for an empty AppStyles-Object
245561b
@danielang
[Android] fix update style of tabbar on display screen
cd926eb
@danielang
[Android] revert eventbus changes
a82441a 
[Android] apply guyca's solution
@danielang
[Android] rn 50 compatibility
be7ea53
@danielang
Merge pull request #2 from wix/master
e8a258f 
update fork
@danielang
Merge pull request #3 from wix/master
b1615ec 
update fork
@danielang
Merge pull request #4 from wix/master
e0219fb 
update fork
@danielang
Merge pull request #5 from wix/master
00c0f60 
update fork
@danielang
remove comment
a397105
@danielang
Merge branch 'master' of https://github.com/danielang/react-native-na…
6659fea 
…vigation
@danielang
Merge branch 'master' of https://github.com/wix/react-native-navigation
4255553 
# Conflicts:
#	android/app/src/main/java/com/reactnativenavigation/params/parsers/StyleParamsParser.java

update fork
@yogevbd yogevbd merged commit abdb6e9 into wix:master Jan 15, 2018
yogevbd added a commit that referenced this pull request Jan 15, 2018
@yogevbd
Revert "setStyle to style the according TabBar (#2524)"
0825baf 
This reverts commit abdb6e9.
yogevbd added a commit that referenced this pull request Jan 15, 2018
@yogevbd
Revert "Revert "setStyle to style the according TabBar (#2524)""
3ae1c6b 
This reverts commit 0825baf.
yogevbd added a commit that referenced this pull request Jan 15, 2018
@yogevbd
Revert "setStyle to style the according TabBar (#2524)"
2f0639b 
This reverts commit abdb6e9.
@danielang
Copy link
Copy Markdown
Contributor Author

danielang commented Jan 15, 2018

@yogevbd: What is the reason for revert this PR? 🙂

@yogevbd
Copy link
Copy Markdown
Collaborator

yogevbd commented Jan 15, 2018

@danielang Something caused the navBar to be presented with delay after pushing a screen.
I'm investigating and will update you soon. thanks 🙂

yogevbd added a commit that referenced this pull request Jan 16, 2018
@yogevbd
fixes #2524
a63601e
yogevbd added a commit that referenced this pull request Jan 21, 2018
@yogevbd
SetStyle fix (#2539)
883dcfe 
* fixes #2524
chilinh added a commit to chilinh/react-native-navigation that referenced this pull request Jan 22, 2018
@chilinh
Merge branch 'r_master'
bce475e 
* r_master:
  SetStyle fix (wix#2539)
  Update ISSUE_TEMPLATE
  fix(start app): show red screen in case an error is thrown while starting the app (wix#2556)
  Xcode 8 fixes
  fixed swizzle in xcode 8
  Back-port insets fix to v1
  Solved doc formatting issues (wix#2544)
  Update README.md (wix#2537)
  Update styling-the-navigator.md
  Adding preferredContentSize (wix#2529)
  Revert "setStyle to style the according TabBar (wix#2524)"
  setStyle to style the according TabBar (wix#2524)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yogevbd yogevbd yogevbd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielang @yogevbd