fixed a bug modal viewController was not deallocated when to call dis…#2843
Merged
Merged
Conversation
Contributor
Author
|
Please review @jasonmerino |
Contributor
|
Can one of the admins verify this patch? |
Contributor
Author
|
@wix Please review the PR. |
Contributor
Conflicts: ios/RCCManagerModule.m
VSchlattinger
added a commit
to VSchlattinger/react-native-navigation
that referenced
this pull request
Apr 9, 2018
Contributor
|
Thank you @masarusanjp this PR fix my issue! |
yogevbd
approved these changes
May 2, 2018
chilinh
added a commit
to chilinh/react-native-navigation
that referenced
this pull request
May 26, 2018
* r_master: (31 commits) Fix syntax error: "screen" is read-only (wix#3237) Revert "- Fixes freeze of passProps on iOS (wix#3220)" (wix#3222) - Fixes freeze of passProps on iOS (wix#3220) allows you to show a lightbox directly after dismissing on ios (wix#1466) Enable RTL support on LeftButton (wix#3154) Trigger build Prevent navBar header background transition in modals, fixes black background in modals navBar Link to root of movieapp repo (wix#3112) Test [skip ci] Revert "Support a “modal” prop for tabbed iOS apps (wix#1578)" Revert "fix build issue" fix build issue fixed a bug modal viewController was not deallocated when to call dismissAllModals (wix#2843) Support a “modal” prop for tabbed iOS apps (wix#1578) Add iPad landscape launch image (wix#2473) Now passing an activity to clearHostOnActivityDestroy (wix#3133) Change CI var env to JENKINS_CI Avoid NPR in SET (wix#3115) Update README.md Update README.md ...
reimertz
pushed a commit
to mavencook/react-native-navigation
that referenced
this pull request
Sep 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug that modal viewcontroller was not unregistered when to call dismissAllModals.
related PR: https://github.com/wix/react-native-navigation/pull/2255/files
Before merging #2255, the controller is always unregistered.
After merging #2255, the controller is often unregistered. So the dismissed controller was not deallocated.