ExPlat: Sync implementation with latest updates from FluxC - #14498
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
renanferrari
marked this pull request as ready for review
April 21, 2021 00:56
3 tasks
…o-fluxc-di-changes Align wpandroid to fluxc di changes
planarvoid
approved these changes
Apr 22, 2021
planarvoid
left a comment
planarvoid
left a comment
Contributor
There was a problem hiding this comment.
Looks good, feel free to merge this after the fluxC update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest ExPlat updates from FluxC introduces some breaking changes, so this PR simply makes sure we handle those so the app doesn't break. Another PR should follow this one introducing actual improvements to the current implementation.
I'll update this PR with a definitive FluxC version once wordpress-mobile/WordPress-FluxC-Android#1969 and wordpress-mobile/WordPress-FluxC-Android#1970 are merged.
To test:
Make sure the app builds.
Regression Notes
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.