Align wpandroid to fluxc di changes - #14515
Merged
planarvoid merged 2 commits intoApr 22, 2021
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
develric
marked this pull request as ready for review
April 22, 2021 11:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns WPAndroid to the latest changes related to DI cleanup introduced with this PR.
I mimic the changes done in a similar alignment in Woo here.
I'm targeting the
feature/sync-explat-updatesbranch since current state of FluxC requires that branch to be merged too.I think that once approved we can:
9621372056be33c1a9c28278a192f56c07339786and hopefully we should be ok I think.
To test:
Check the app builds and smoke test.
Regression Notes
Potential unintended areas of impact
None in theory 😄 .
What I did to test those areas of impact (or what existing automated tests I relied on)
Smoke testing and already available CI.
What automated tests I added (or what prevented me from doing so)
Current CI should be covering already.
PR submission checklist:
RELEASE-NOTES.txtif necessary.