Skip to content

Align wpandroid to fluxc di changes - #14515

Merged
planarvoid merged 2 commits into
feature/sync-explat-updatesfrom
fix/align-wpandroid-to-fluxc-di-changes
Apr 22, 2021
Merged

Align wpandroid to fluxc di changes#14515
planarvoid merged 2 commits into
feature/sync-explat-updatesfrom
fix/align-wpandroid-to-fluxc-di-changes

Conversation

@develric

@develric develric commented Apr 22, 2021

Copy link
Copy Markdown
Contributor

This PR aligns WPAndroid to the latest changes related to DI cleanup introduced with this PR.

I mimic the changes done in a similar alignment in Woo here.

I'm targeting the feature/sync-explat-updates branch since current state of FluxC requires that branch to be merged too.

I think that once approved we can:

and hopefully we should be ok I think.

To test:

Check the app builds and smoke test.

Regression Notes

  1. Potential unintended areas of impact
    None in theory 😄 .

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Smoke testing and already available CI.

  3. What automated tests I added (or what prevented me from doing so)
    Current CI should be covering already.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@develric develric added this to the 17.3 milestone Apr 22, 2021
@develric
develric requested a review from planarvoid April 22, 2021 11:10
@peril-wordpress-mobile

Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile

Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APK here.

@develric
develric marked this pull request as ready for review April 22, 2021 11:31

@planarvoid planarvoid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@planarvoid
planarvoid merged commit a8a7cf2 into feature/sync-explat-updates Apr 22, 2021
@planarvoid
planarvoid deleted the fix/align-wpandroid-to-fluxc-di-changes branch April 22, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants