Removes Land In the Editor ExPlat experiment - #16145
Merged
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
antonis
marked this pull request as ready for review
March 22, 2022 15:17
mkevins
approved these changes
Mar 23, 2022
mkevins
left a comment
mkevins
left a comment
Contributor
There was a problem hiding this comment.
These code change look good, and I also tested the flows (both from logged out and from a logged in user), and the flag is working as described. Nice work addressing this Antonis! 👍
# Conflicts: # WordPress/build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the Land on the editor ExPlat experiment with a development feature flag. This is needed to avoid pinging the ExPlat server now that the experiment is finished
To test:
Use the test cases of the A/B test Land In the Editor PR verifying that:
LAND_ON_THE_EDITORflag is disabled the control flow appliesLAND_ON_THE_EDITORflag is enabled the treatment flow appliesRegression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
Updated existing
MySiteViewModelTesttestPR submission checklist:
RELEASE-NOTES.txtif necessary.