A/B test Land In the Editor - #15627
Merged
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
antonis
force-pushed
the
feature/land-in-the-editor
branch
2 times, most recently
from
November 29, 2021 15:26
4df43be to
0d556b3
Compare
antonis
force-pushed
the
feature/land-in-the-editor
branch
from
January 20, 2022 11:10
494425c to
cf984bf
Compare
antonis
marked this pull request as ready for review
January 20, 2022 13:26
mkevins
reviewed
Jan 20, 2022
Comment on lines
+731
to
+733
| if (landOnTheEditorABExperiment.getVariation() is Control) { | ||
| return | ||
| } |
Contributor
There was a problem hiding this comment.
Curious why we are checking this twice?
Contributor
Author
mkevins
approved these changes
Jan 21, 2022
mkevins
left a comment
Contributor
There was a problem hiding this comment.
The code looks good.
I tested each user path in the description on a Pixel 3a (physical device) using the staging bookmarklet tool to switch between control and treatment groups for my user account. Each case works as described.
Also, I ran all the additional tests locally (thanks for adding the extra tests 😄 ) and everything is working as expected as well.
Nice work on this Antonis! 👍
3 tasks
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an A/B experiment that opens the home page for editing after the last step in site creation.
This flow is conditioned on an ExPlat experiment named "wpandroid_land_in_the_editor_phase1_v3" and should leave the current behavior intact for the control variation.
To test
Note: To change the experiment variation between
Control(default) andTreatment(experiment):wpandroid_land_in_the_editor_phase1_v3(internal ref:pbxNRc-1fJ-p2)Bookmarklettooltip to set theControlorTreatmentvariation for your user.Alternatively you may use a proxy (e.g. Charlie) to intercept the call to the experiments endpoint (
/wpcom/v2/experiments/) and return the desired variation (detailed instructions in this previous experiment). E.g.Control: Login or New user
Controlvariation assigned (check note above)Want a little help to manage your sitedialogVideo
login-control.mp4
Treatment: Login or New user
Treatmentvariation assigned (check note above)landing_editor_shownanalytics event is emittedWant a little help to manage your sitedialogVideo
login-treat.mp4
Control: Existing or Logged in user
Want a little help to manage your sitedialogVideo
existing-control.mp4
Treatment: Existing or Logged in user
Treatmentvariation assigned (check note above)landing_editor_shownanalytics event is emittedWant a little help to manage your sitedialogVideo
existing-treat.mp4
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
Relied on existing tests
What automated tests I added (or what prevented me from doing so)
Added tests in
MySiteViewModelTest,EditorActionsProviderTestandGetButtonUiStateUseCaseTestPR submission checklist:
RELEASE-NOTES.txtif necessary.