Detekt - Resolve/Suppress All Baseline Warnings - Long methods warnings_ MediaPickerActivity - #17355
Conversation
ParaskP7
left a comment
There was a problem hiding this comment.
👋 @Hoossayn !
Thank you so much for re-opening this PR! 🎉
I reviewed and tested this PR as per the description, along with triggering CI on it via a draft #17361 PR, which I just pushed on the main repo.
Everything LGTM, you did a great job in applying all my suggestion from the previous PR, including all, the PR/commit description and code related notes, kudos on that, I much appreciate the effort you put into this.
👋🏾 @ParaskP7 thank you so much, will open another PR for mediaPickerFragment/viewmodel soon. will do well to adhere to all the suggestions from previous PR |
Parent: #17010
This PR resolved/suppress all complexity related LongMethod warnings for the WordPress module (see docs here):
1x LongMethod (Resolve: 8594712 + f5cbb2e)To test:
There is nothing much to test here.
Verifying that all the CI checks are successful should be enough (especially the detekt check).
However, if you really want to be thorough, you could smoke test the WordPress and/or Jetpack apps to verify that everything works as expected on every screen that relates to these changes.
STEPS
Go to the menu tab
click on media option
click on the upload media button or the (+) button at the top right corner
select choose from device
select an image
Regression Notes
Potential unintended areas of impact
can't think of any
What I did to test those areas of impact (or what existing automated tests I relied on)
See
To testsection above.What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.