Skip to content

Detekt - Resolve/Suppress All Baseline Warnings - Long methods warnings_ MediaPickerActivity #17355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ParaskP7 merged 2 commits into from
Oct 20, 2022
Merged

Detekt - Resolve/Suppress All Baseline Warnings - Long methods warnings_ MediaPickerActivity #17355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5cbb2e
Refactor: Extract take a photo method for media picker activity
Hoossayn Oct 19, 2022
8594712
Refactor: Extract edit image intent method for media picker activity
Hoossayn Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 42 additions & 43 deletions WordPress/src/main/java/org/wordpress/android/ui/mediapicker/MediaPickerActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ class MediaPickerActivity : LocaleAwareActivity(), MediaPickerListener {
return super.onOptionsItemSelected(item)
}

@Suppress("DEPRECATION", "OVERRIDE_DEPRECATION", "LongMethod", "NestedBlockDepth")
@Suppress("DEPRECATION", "OVERRIDE_DEPRECATION")
override fun onActivityResult(
requestCode: Int,
resultCode: Int,
Expand All @@ -191,55 +191,54 @@ class MediaPickerActivity : LocaleAwareActivity(), MediaPickerListener {
return
}
}
TAKE_PHOTO -> {
try {
val intent = Intent()
mediaCapturePath!!.let {
WPMediaUtils.scanMediaFile(this, it)
val f = File(it)
val capturedImageUri = listOf(Uri.fromFile(f))
if (mediaPickerSetup.queueResults) {
intent.putQueuedUris(capturedImageUri)
} else {
intent.putUris(capturedImageUri)
}
intent.putExtra(
EXTRA_MEDIA_SOURCE,
ANDROID_CAMERA.name
)
}
intent
} catch (e: RuntimeException) {
AppLog.e(MEDIA, e)
null
}
}
IMAGE_EDITOR_EDIT_IMAGE -> {
data?.let {
val intent = Intent()
val uris = WPMediaUtils.retrieveImageEditorResult(data)
if (mediaPickerSetup.queueResults) {
intent.putQueuedUris(uris)
} else {
intent.putUris(uris)
}
intent.putExtra(
EXTRA_MEDIA_SOURCE,
APP_PICKER.name
)
intent
}
}
else -> {
data
}
TAKE_PHOTO -> takeAPhoto()
IMAGE_EDITOR_EDIT_IMAGE -> data?.let { editImageIntent(it) }
else -> data
}

intent?.let {
setResult(Activity.RESULT_OK, intent)
finish()
}
}

private fun editImageIntent(data: Intent?): Intent {
val intent = Intent()
val uris = WPMediaUtils.retrieveImageEditorResult(data)
if (mediaPickerSetup.queueResults) {
intent.putQueuedUris(uris)
} else {
intent.putUris(uris)
}
intent.putExtra(
EXTRA_MEDIA_SOURCE,
APP_PICKER.name
)
return intent
}

private fun takeAPhoto() = try {
val intent = Intent()
mediaCapturePath!!.let {
WPMediaUtils.scanMediaFile(this, it)
val f = File(it)
val capturedImageUri = listOf(Uri.fromFile(f))
if (mediaPickerSetup.queueResults) {
intent.putQueuedUris(capturedImageUri)
} else {
intent.putUris(capturedImageUri)
}
intent.putExtra(
EXTRA_MEDIA_SOURCE,
ANDROID_CAMERA.name
)
}
intent
} catch (e: RuntimeException) {
AppLog.e(MEDIA, e)
null
}

private fun launchChooserWithContext(openSystemPicker: OpenSystemPicker, uiHelpers: UiHelpers) {
WPMediaUtils.launchChooserWithContext(this, openSystemPicker, uiHelpers, MEDIA_LIBRARY)
}
Expand Down